Skip to content

Commit fc158cb

Browse files
committed
removing unused functions and unused latex handling
1 parent a41e286 commit fc158cb

File tree

2 files changed

+3
-53
lines changed

2 files changed

+3
-53
lines changed

sphinx_exercise/nodes.py

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
from docutils import nodes as docutil_nodes
1313
from sphinx import addnodes as sphinx_nodes
1414
from sphinx.writers.latex import LaTeXTranslator
15-
from .utils import get_node_number, list_rindex
1615
from .latex import LaTeXMarkup
1716

1817
logger = logging.getLogger(__name__)
@@ -89,17 +88,6 @@ def is_extension_node(node):
8988

9089
# Visit and Depart Functions
9190

92-
# TODO: Review _depart_nodes_latex to see if these pop methods
93-
# are really needed.
94-
95-
96-
def _depart_nodes_latex(self, node, title, pop_index=False):
97-
""" Function to handle depart_node for latex. """
98-
idx = list_rindex(self.body, LaTeX.visit_admonition()) + 2
99-
if pop_index:
100-
self.body.pop(idx)
101-
self.body.append(LaTeX.depart_admonition())
102-
10391

10492
def visit_exercise_node(self, node: Node) -> None:
10593
if isinstance(self, LaTeXTranslator):
@@ -114,10 +102,8 @@ def visit_exercise_node(self, node: Node) -> None:
114102

115103

116104
def depart_exercise_node(self, node: Node) -> None:
117-
typ = node.attributes.get("type", "")
118105
if isinstance(self, LaTeXTranslator):
119-
120-
_depart_nodes_latex(self, node, f"{typ.title()} ")
106+
self.body.append(LaTeX.depart_admonition())
121107
else:
122108
self.body.append("</div>")
123109

@@ -139,10 +125,8 @@ def visit_exercise_enumerable_node(self, node: Node) -> None:
139125

140126

141127
def depart_exercise_enumerable_node(self, node: Node) -> None:
142-
typ = node.attributes.get("type", "")
143128
if isinstance(self, LaTeXTranslator):
144-
number = get_node_number(self, node, typ)
145-
_depart_nodes_latex(self, node, f"{typ.title()} {number} ")
129+
self.body.append(LaTeX.depart_admonition())
146130
else:
147131
self.body.append("</div>")
148132
self.body.append("\n")
@@ -169,10 +153,8 @@ def visit_solution_node(self, node: Node) -> None:
169153

170154

171155
def depart_solution_node(self, node: Node) -> None:
172-
typ = node.attributes.get("type", "")
173156
if isinstance(self, LaTeXTranslator):
174-
number = get_node_number(self, node, typ)
175-
_depart_nodes_latex(self, node, f"{typ.title()} {number} ")
157+
self.body.append(LaTeX.depart_admonition())
176158
else:
177159
self.body.append("</div>")
178160
self.body.append("\n")

sphinx_exercise/utils.py

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# Utility functions
22

33
from sphinx.writers.latex import LaTeXTranslator
4-
from docutils import nodes as docutil_nodes
54

65

76
def find_parent(env, node, parent_tag):
@@ -37,34 +36,3 @@ def get_node_number(self, node, typ) -> str:
3736
fignumbers = self.builder.env.toc_fignumbers.get(docname, {})
3837
number = fignumbers.get(typ, {}).get(ids, ())
3938
return ".".join(map(str, number))
40-
41-
42-
def has_math_child(node):
43-
""" Check if a parent node as a math child node. """
44-
45-
for item in node:
46-
if isinstance(item, docutil_nodes.math):
47-
return True
48-
return False
49-
50-
51-
def get_refuri(node):
52-
""" Check both refuri and refid, to see which one is available. """
53-
54-
id_ = ""
55-
if node.get("refuri", ""):
56-
id_ = node.get("refuri", "")
57-
58-
if node.get("refid", ""):
59-
id_ = node.get("refid", "")
60-
61-
return id_.split("#")[-1]
62-
63-
64-
def list_rindex(li, x) -> int:
65-
"""Getting the last occurence of an item in a list."""
66-
67-
for i in reversed(range(len(li))):
68-
if li[i] == x:
69-
return i
70-
raise ValueError("{} is not in list".format(x))

0 commit comments

Comments
 (0)