Merge pull request #852 from bcmmbaga/close-respBody

Katrina Owen · web-flow · commit a1ddb0c8d13e · 2019-06-26T09:21:19.000-06:00
Ensure closing response body
diff --git a/api/client.go b/api/client.go
@@ -85,6 +85,8 @@ func (c *Client) TokenIsValid() (bool, error) {
 	if err != nil {
 		return false, err
 	}
+	defer resp.Body.Close()
+
 	return resp.StatusCode == http.StatusOK, nil
 }
 
@@ -99,6 +101,8 @@ func (c *Client) IsPingable() error {
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
+
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("API returned %s", resp.Status)
 	}

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,8 @@ func (c *Client) TokenIsValid() (bool, error) {`
`85`	`85`	`if err != nil {`
`86`	`86`	`return false, err`
`87`	`87`	`}`
	`88`	`+ defer resp.Body.Close()`
	`89`	`+`
`88`	`90`	`return resp.StatusCode == http.StatusOK, nil`
`89`	`91`	`}`
`90`	`92`
`@@ -99,6 +101,8 @@ func (c *Client) IsPingable() error {`
`99`	`101`	`if err != nil {`
`100`	`102`	`return err`
`101`	`103`	`}`
	`104`	`+ defer resp.Body.Close()`
	`105`	`+`
`102`	`106`	`if resp.StatusCode != http.StatusOK {`
`103`	`107`	`return fmt.Errorf("API returned %s", resp.Status)`
`104`	`108`	`}`