prime-factors: Update to latest (#825)

* sync tests

* add generator and generate tests

* update function template in starter file

* simplify example solution

* update contributors

Author: tasxatzial

exercises/practice/prime-factors/.meta/config.json

@@ -10,7 +10,8 @@
     "jgwhite",
     "kytrinyx",
     "mathias",
-    "yurrriq"
+    "yurrriq",
+    "tasxatzial"
   ],
   "files": {
     "solution": [

exercises/practice/prime-factors/.meta/example.clj

@@ -1,14 +1,12 @@
 (ns prime-factors)
 
-(defn- least-prime-divisor
-  [number]
-  (or (first
-       (filter #(zero? (rem number %1))
-               (range 2 (inc (/ number 2)))))
-      number))
-
-(defn of [number]
-  (if
-   (< number 2) []
-   (let [divisor (least-prime-divisor number)]
-     (into [divisor] (of (/ number divisor))))))
+(defn of
+  [n]
+  (loop [result []
+         candidate 2
+         n n]
+    (if (= n 1)
+      result
+      (if (zero? (mod n candidate))
+        (recur (conj result candidate) candidate (quot n candidate))
+        (recur result (inc candidate) n)))))

exercises/practice/prime-factors/.meta/generator.tpl

@@ -0,0 +1,9 @@
+(ns prime-factors-test
+  (:require [clojure.test :refer [deftest testing is]]
+            prime-factors))
+
+{{#test_cases.factors}}
+(deftest of_test_{{idx}}
+  (testing {{context}}
+    (is (= {{expected}} (prime-factors/of {{input.value}})))))
+{{/test_cases.factors}}

exercises/practice/prime-factors/.meta/tests.toml

@@ -1,19 +1,41 @@
-# This is an auto-generated file. Regular comments will be removed when this
-# file is regenerated. Regenerating will not touch any manually added keys,
-# so comments can be added in a "comment" key.
+# This is an auto-generated file.
+#
+# Regenerating this file via `configlet sync` will:
+# - Recreate every `description` key/value pair
+# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications
+# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion)
+# - Preserve any other key/value pair
+#
+# As user-added comments (using the # character) will be removed when this file
+# is regenerated, comments can be added via a `comment` key.
 
 [924fc966-a8f5-4288-82f2-6b9224819ccd]
 description = "no factors"
 
 [17e30670-b105-4305-af53-ddde182cb6ad]
 description = "prime number"
 
+[238d57c8-4c12-42ef-af34-ae4929f94789]
+description = "another prime number"
+
 [f59b8350-a180-495a-8fb1-1712fbee1158]
 description = "square of a prime"
 
+[756949d3-3158-4e3d-91f2-c4f9f043ee70]
+description = "product of first prime"
+
 [bc8c113f-9580-4516-8669-c5fc29512ceb]
 description = "cube of a prime"
 
+[7d6a3300-a4cb-4065-bd33-0ced1de6cb44]
+description = "product of second prime"
+
+[073ac0b2-c915-4362-929d-fc45f7b9a9e4]
+description = "product of third prime"
+
+[6e0e4912-7fb6-47f3-a9ad-dbcd79340c75]
+description = "product of first and second prime"
+
 [00485cd3-a3fe-4fbe-a64a-a4308fc1f870]
 description = "product of primes and non-primes"
 

exercises/practice/prime-factors/src/prime_factors.clj

@@ -1,5 +1,7 @@
 (ns prime-factors)
 
-(defn of [] ;; <- arglist goes here
-      ;; your code goes here
-)
+(defn of
+  "Returns the prime factors of the given number."
+  [num]
+  ;; function body
+  )

exercises/practice/prime-factors/test/prime_factors_test.clj

@@ -1,36 +1,63 @@
 (ns prime-factors-test
-  (:require [clojure.test :refer [deftest is]]
+  (:require [clojure.test :refer [deftest testing is]]
             prime-factors))
 
-(deftest one
-  (is (= [] (prime-factors/of 1))))
-
-(deftest two
-  (is (= [2] (prime-factors/of 2))))
-
-(deftest three
-  (is (= [3] (prime-factors/of 3))))
-
-(deftest four
-  (is (= [2, 2] (prime-factors/of 4))))
-
-(deftest six
-  (is (= [2, 3] (prime-factors/of 6))))
-
-(deftest eight
-  (is (= [2, 2, 2] (prime-factors/of 8))))
-
-(deftest nine
-  (is (= [3, 3] (prime-factors/of 9))))
-
-(deftest twenty-seven
-  (is (= [3, 3, 3] (prime-factors/of 27))))
-
-(deftest six-hundred-twenty-five
-  (is (= [5, 5, 5, 5] (prime-factors/of 625))))
-
-(deftest a-large-number
-  (is (= [5, 17, 23, 461] (prime-factors/of 901255))))
-
-(deftest a-huge-number
-  (is (= [11, 9539, 894119] (prime-factors/of 93819012551))))
+(deftest of_test_1
+  (testing "no factors"
+    (is (= []
+           (prime-factors/of 1)))))
+
+(deftest of_test_2
+  (testing "prime number"
+    (is (= [2]
+           (prime-factors/of 2)))))
+
+(deftest of_test_3
+  (testing "another prime number"
+    (is (= [3]
+           (prime-factors/of 3)))))
+
+(deftest of_test_4
+  (testing "square of a prime"
+    (is (= [3 3]
+           (prime-factors/of 9)))))
+
+(deftest of_test_5
+  (testing "product of first prime"
+    (is (= [2 2]
+           (prime-factors/of 4)))))
+
+(deftest of_test_6
+  (testing "cube of a prime"
+    (is (= [2 2 2]
+           (prime-factors/of 8)))))
+
+(deftest of_test_7
+  (testing "product of second prime"
+    (is (= [3 3 3]
+           (prime-factors/of 27)))))
+
+(deftest of_test_8
+  (testing "product of third prime"
+    (is (= [5 5 5 5]
+           (prime-factors/of 625)))))
+
+(deftest of_test_9
+  (testing "product of first and second prime"
+    (is (= [2 3]
+           (prime-factors/of 6)))))
+
+(deftest of_test_10
+  (testing "product of primes and non-primes"
+    (is (= [2 2 3]
+           (prime-factors/of 12)))))
+
+(deftest of_test_11
+  (testing "product of primes"
+    (is (= [5 17 23 461]
+           (prime-factors/of 901255)))))
+
+(deftest of_test_12
+  (testing "factors include a large prime"
+    (is (= [11 9539 894119]
+           (prime-factors/of 93819012551)))))