Fix warnings (#2391)

[no important files changed]

Author: ErikSchierboom

exercises/concept/hyperia-forex/.meta/Exemplar.cs

@@ -1,3 +1,6 @@
+#pragma warning disable CS0660
+#pragma warning disable CS0661
+
 public struct CurrencyAmount
 {
     private decimal amount;
@@ -94,3 +97,6 @@ public static implicit operator decimal(CurrencyAmount @this)
         return @this.amount;
     }
 }
+
+#pragma warning restore CS0660
+#pragma warning restore CS0661

exercises/practice/bank-account/.meta/Generator.tpl

@@ -28,7 +28,7 @@ public class {{ testClass }}
 {
     {{- for test in tests }}
     [Fact{{ if !for.first }}(Skip = "Remove this Skip property to run this test"){{ end }}]
-    public void {{ test.testMethod }}()
+    public {{ if test.scenarios | array.contains "concurrent" }}async Task{{ else }}void{{ end }} {{ test.testMethod }}()
     {
         var account = new {{ testedClass }}();
         {{- for op in test.input.operations }}
@@ -51,7 +51,7 @@ public class {{ testClass }}
                         {{- end -}}
                     }
                 }));
-                Task.WaitAll(tasks.ToArray());
+                await Task.WhenAll(tasks.ToArray());
             }
             {{- else }}
             account.{{ op | to_call }};

exercises/practice/bank-account/BankAccountTests.cs

@@ -148,7 +148,7 @@ public void Cannot_deposit_negative()
     }
 
     [Fact(Skip = "Remove this Skip property to run this test")]
-    public void Can_handle_concurrent_transactions()
+    public async Task Can_handle_concurrent_transactions()
     {
         var account = new BankAccount();
         account.Open();
@@ -163,7 +163,7 @@ public void Can_handle_concurrent_transactions()
                     account.Withdraw(1m);
                 }
             }));
-            Task.WaitAll(tasks.ToArray());
+            await Task.WhenAll(tasks.ToArray());
         }
         Assert.Equal(0m, account.Balance);
     }

exercises/practice/go-counting/.meta/Generator.tpl

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using Xunit;
 
 public class {{ testClass }}
@@ -26,7 +27,7 @@ public class {{ testClass }}
             var expectedOwner = {{ test.expected.owner | string.downcase | enum "Owner" }};
             var expectedCoordinates = new HashSet<(int, int)>{{ if test.expected.territory.empty? }}(){{ else }}{ {{ for territory in test.expected.territory }}({{ territory | array.join ", " }}){{ if !for.last }}, {{ end }}{{ end }} }{{ end }};
             Assert.Equal(expectedOwner, territoryOwner);
-            Assert.Equal(expectedCoordinates, territoryCoordinates);
+            Assert.Equal(expectedCoordinates, territoryCoordinates.ToHashSet());
         {{- else if test.property == "territories" }}
             var actual = sut.Territories();
             var expected = new Dictionary<Owner, HashSet<(int, int)>>

exercises/practice/go-counting/GoCountingTests.cs

@@ -15,7 +15,7 @@ public void Black_corner_territory_on_5x5_board()
         var expectedOwner = Owner.Black;
         var expectedCoordinates = new HashSet<(int, int)> { (0, 0), (0, 1), (1, 0) };
         Assert.Equal(expectedOwner, territoryOwner);
-        Assert.Equal(expectedCoordinates, territoryCoordinates);
+        Assert.Equal(expectedCoordinates, territoryCoordinates.ToHashSet());
     }
 
     [Fact(Skip = "Remove this Skip property to run this test")]
@@ -33,7 +33,7 @@ public void White_center_territory_on_5x5_board()
         var expectedOwner = Owner.White;
         var expectedCoordinates = new HashSet<(int, int)> { (2, 3) };
         Assert.Equal(expectedOwner, territoryOwner);
-        Assert.Equal(expectedCoordinates, territoryCoordinates);
+        Assert.Equal(expectedCoordinates, territoryCoordinates.ToHashSet());
     }
 
     [Fact(Skip = "Remove this Skip property to run this test")]
@@ -51,7 +51,7 @@ public void Open_corner_territory_on_5x5_board()
         var expectedOwner = Owner.None;
         var expectedCoordinates = new HashSet<(int, int)> { (0, 3), (0, 4), (1, 4) };
         Assert.Equal(expectedOwner, territoryOwner);
-        Assert.Equal(expectedCoordinates, territoryCoordinates);
+        Assert.Equal(expectedCoordinates, territoryCoordinates.ToHashSet());
     }
 
     [Fact(Skip = "Remove this Skip property to run this test")]
@@ -69,7 +69,7 @@ public void A_stone_and_not_a_territory_on_5x5_board()
         var expectedOwner = Owner.None;
         var expectedCoordinates = new HashSet<(int, int)>();
         Assert.Equal(expectedOwner, territoryOwner);
-        Assert.Equal(expectedCoordinates, territoryCoordinates);
+        Assert.Equal(expectedCoordinates, territoryCoordinates.ToHashSet());
     }
 
     [Fact(Skip = "Remove this Skip property to run this test")]