Skip to content

Commit 1361988

Browse files
BNAndrasBNAndras
committed
Apply code review
1 parent d5c04db commit 1361988

File tree

4 files changed

+128
-5
lines changed

4 files changed

+128
-5
lines changed

‎exercises/practice/bottle-song/.meta/Generator.tpl‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
1-
using Xunit;
2-
31
public class {{ testClass }}
42
{
53
{{- for test in tests }}
64
[Fact{{ if !for.first }}(Skip = "Remove this Skip property to run this test"){{ end }}]
75
public void {{ test.testMethod }}()
86
{
9-
Assert.Equal({{ test.expected }}, {{ testedClass }}.{{ test.testedMethod }}({{ test.input.startBottles }}, {{ test.input.takeDown }}));
7+
string[] expected = [
8+
{{- for line in test.expected }}
9+
{{ line | string.literal }}{{- if !for.last }},{{ end -}}
10+
{{ end }}
11+
];
12+
Assert.Equal(expected, {{ testedClass }}.{{ test.testedMethod }}({{ test.input.startBottles }}, {{ test.input.takeDown }}));
1013
}
1114
{{ end -}}
1215
}

‎exercises/practice/bottle-song/BottleSong.cs‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
using System;
2-
31
public static class BottleSong
42
{
53
public static string Recite(int startBottles, int takeDown)

‎exercises/practice/bottle-song/BottleSong.csproj‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33
<TargetFramework>net9.0</TargetFramework>
4+
<ImplicitUsings>enable</ImplicitUsings>
5+
<Nullable>enable</Nullable>
46
<IsPackable>false</IsPackable>
7+
<IsTestProject>true</IsTestProject>
8+
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
59
</PropertyGroup>
10+
<ItemGroup>
11+
<Using Include="Xunit" />
12+
</ItemGroup>
613
<ItemGroup>
714
<PackageReference Include="Exercism.Tests" Version="0.1.0-beta1" />
815
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />

‎exercises/practice/bottle-song/packages.lock.json‎

Lines changed: 115 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,115 @@
1+
{
2+
"version": 1,
3+
"dependencies": {
4+
"net9.0": {
5+
"Exercism.Tests": {
6+
"type": "Direct",
7+
"requested": "[0.1.0-beta1, )",
8+
"resolved": "0.1.0-beta1",
9+
"contentHash": "g+ZEvkReJ/ghRMpSw2qrSzICQDygKcR2nokvigiQXZTUxFplii8ZSFFKrGKEn6jIHuIeMeBFUFpk4CkyVw+6wA==",
10+
"dependencies": {
11+
"xunit.extensibility.core": "2.4.1"
12+
}
13+
},
14+
"Microsoft.NET.Test.Sdk": {
15+
"type": "Direct",
16+
"requested": "[17.12.0, )",
17+
"resolved": "17.12.0",
18+
"contentHash": "kt/PKBZ91rFCWxVIJZSgVLk+YR+4KxTuHf799ho8WNiK5ZQpJNAEZCAWX86vcKrs+DiYjiibpYKdGZP6+/N17w==",
19+
"dependencies": {
20+
"Microsoft.CodeCoverage": "17.12.0",
21+
"Microsoft.TestPlatform.TestHost": "17.12.0"
22+
}
23+
},
24+
"xunit": {
25+
"type": "Direct",
26+
"requested": "[2.8.1, )",
27+
"resolved": "2.8.1",
28+
"contentHash": "MLBz2NQp3rtSIoJdjj3DBEr/EeOFlQYF3oCCljat3DY9GQ7yYmtjIAv8Zyfm5BcwYso5sjvIe5scuHaJPVCGIQ==",
29+
"dependencies": {
30+
"xunit.analyzers": "1.14.0",
31+
"xunit.assert": "2.8.1",
32+
"xunit.core": "[2.8.1]"
33+
}
34+
},
35+
"xunit.runner.visualstudio": {
36+
"type": "Direct",
37+
"requested": "[3.0.1, )",
38+
"resolved": "3.0.1",
39+
"contentHash": "lbyYtsBxA8Pz8kaf5Xn/Mj1mL9z2nlBWdZhqFaj66nxXBa4JwiTDm4eGcpSMet6du9TOWI6bfha+gQR6+IHawg=="
40+
},
41+
"Microsoft.CodeCoverage": {
42+
"type": "Transitive",
43+
"resolved": "17.12.0",
44+
"contentHash": "4svMznBd5JM21JIG2xZKGNanAHNXplxf/kQDFfLHXQ3OnpJkayRK/TjacFjA+EYmoyuNXHo/sOETEfcYtAzIrA=="
45+
},
46+
"Microsoft.TestPlatform.ObjectModel": {
47+
"type": "Transitive",
48+
"resolved": "17.12.0",
49+
"contentHash": "TDqkTKLfQuAaPcEb3pDDWnh7b3SyZF+/W9OZvWFp6eJCIiiYFdSB6taE2I6tWrFw5ywhzOb6sreoGJTI6m3rSQ==",
50+
"dependencies": {
51+
"System.Reflection.Metadata": "1.6.0"
52+
}
53+
},
54+
"Microsoft.TestPlatform.TestHost": {
55+
"type": "Transitive",
56+
"resolved": "17.12.0",
57+
"contentHash": "MiPEJQNyADfwZ4pJNpQex+t9/jOClBGMiCiVVFuELCMSX2nmNfvUor3uFVxNNCg30uxDP8JDYfPnMXQzsfzYyg==",
58+
"dependencies": {
59+
"Microsoft.TestPlatform.ObjectModel": "17.12.0",
60+
"Newtonsoft.Json": "13.0.1"
61+
}
62+
},
63+
"Newtonsoft.Json": {
64+
"type": "Transitive",
65+
"resolved": "13.0.1",
66+
"contentHash": "ppPFpBcvxdsfUonNcvITKqLl3bqxWbDCZIzDWHzjpdAHRFfZe0Dw9HmA0+za13IdyrgJwpkDTDA9fHaxOrt20A=="
67+
},
68+
"System.Reflection.Metadata": {
69+
"type": "Transitive",
70+
"resolved": "1.6.0",
71+
"contentHash": "COC1aiAJjCoA5GBF+QKL2uLqEBew4JsCkQmoHKbN3TlOZKa2fKLz5CpiRQKDz0RsAOEGsVKqOD5bomsXq/4STQ=="
72+
},
73+
"xunit.abstractions": {
74+
"type": "Transitive",
75+
"resolved": "2.0.3",
76+
"contentHash": "pot1I4YOxlWjIb5jmwvvQNbTrZ3lJQ+jUGkGjWE3hEFM0l5gOnBWS+H3qsex68s5cO52g+44vpGzhAt+42vwKg=="
77+
},
78+
"xunit.analyzers": {
79+
"type": "Transitive",
80+
"resolved": "1.14.0",
81+
"contentHash": "KcFBmV2150xZHPUebV3YLR5gGl8R4wLuPOoxMiwCf1L4bL8ls0dcwtGFzr6NvQRgg6dWgSqbE52I6SYyeB0VnQ=="
82+
},
83+
"xunit.assert": {
84+
"type": "Transitive",
85+
"resolved": "2.8.1",
86+
"contentHash": "DDM18ur+PeNFhQ4w/vO+uvCUy8hA3OS5+AMf/CFov9Wco7Le49zzj0hovRWwa8f/3vaUfjL5r+IkPvqEHu2IIg=="
87+
},
88+
"xunit.core": {
89+
"type": "Transitive",
90+
"resolved": "2.8.1",
91+
"contentHash": "Ng4Q/DOwotESPl5CufcdqgP6O2KDpdEcIvNfA3upzfCiBrkj5WsmLhf/XUsCVolzvHA7b1WUlyeTo7j1ulG4gQ==",
92+
"dependencies": {
93+
"xunit.extensibility.core": "[2.8.1]",
94+
"xunit.extensibility.execution": "[2.8.1]"
95+
}
96+
},
97+
"xunit.extensibility.core": {
98+
"type": "Transitive",
99+
"resolved": "2.8.1",
100+
"contentHash": "ilfAsxEhpne9AXXf3W+O65mRgGum94m2xHYm1yeJ1m7eiINM6OOwpaHhoNC/KWEQ2u/WF6/XiEs+Q0TOq7hiGA==",
101+
"dependencies": {
102+
"xunit.abstractions": "2.0.3"
103+
}
104+
},
105+
"xunit.extensibility.execution": {
106+
"type": "Transitive",
107+
"resolved": "2.8.1",
108+
"contentHash": "38UnJW+64Wn8QIabujcNEw0HKvWw2AlYCgU8GNwCCDqyrSuRYb7zwetn7SHoHfbL9e9FAvEiAMXmc2wSUY8sVQ==",
109+
"dependencies": {
110+
"xunit.extensibility.core": "[2.8.1]"
111+
}
112+
}
113+
}
114+
}
115+
}

0 commit comments

Comments
 (0)