-
-
Notifications
You must be signed in to change notification settings - Fork 373
fix: Convert parallel-letter-frequency exercise to use async/await #2440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Convert parallel-letter-frequency exercise to use async/await #2440
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
@KaranChadha10 CI is failing |
|
@ErikSchierboom sure let me check. |
5e61a96 to
c72349a
Compare
|
@ErikSchierboom I've now updated the code. The checks should be passing now. Please let me know if there's anything else that needs adjustment! |
|
|
||
| [Fact(Skip = "Remove this Skip property to run this test")] | ||
| public void One_text_with_one_letter() | ||
| [Fact] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you re-add the skips on all but the first test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, @ErikSchierboom kindly review, thanks.
|
Thanks! |
Summary
Converts the parallel-letter-frequency exercise from using PLINQ (
AsParallel()) to proper async/await patterns withTask.RunandTask.WhenAll.Changes Made
Calculateto returnTask<Dictionary<char, int>>instead ofDictionary<char, int>async Taskandawaitthe Calculate methodAsParallel().Aggregate()withTask.Run+Task.WhenAllfor better async/parallel demonstrationIssue link: #1894