binary-search uses Extended

We improve the exercise suite's coverage of numeric types.

resolves #41

Author: keiravillekode

exercises/practice/binary-search/.meta/config.json

@@ -2,6 +2,9 @@
   "authors": [
     "jimmytty"
   ],
+  "contributors": [
+    "keiravillekode"
+  ],
   "files": {
     "solution": [
       "BinarySearch.pas"

exercises/practice/binary-search/.meta/example.pas

@@ -5,15 +5,15 @@
 interface
 
 type
-  TIntArray = Array Of Integer;
+  TExtendedArray = Array Of Extended;
 
-function find(const AArray: TIntArray; const AValue : integer) : integer;
+function find(const AArray: TExtendedArray; const AValue : Extended) : Integer;
 
 implementation
 
 uses SysUtils;
 
-function find(const AArray: TIntArray; const AValue : integer) : integer;
+function find(const AArray: TExtendedArray; const AValue : Extended) : Integer;
 var
   i, j, mid : integer;
   WasFound  : boolean;

exercises/practice/binary-search/BinarySearch.pas

@@ -5,18 +5,18 @@
 interface
 
 type
-  TIntArray = Array Of Integer;
+  TExtendedArray = Array Of Extended;
 
-function find(const AArray: TIntArray; const AValue : integer) : integer;
+function find(const AArray: TExtendedArray; const AValue : Extended) : Integer;
 
 implementation
 
 uses SysUtils;
 
-function find(const AArray: TIntArray; const AValue : integer) : integer;
+function find(const AArray: TExtendedArray; const AValue : Extended) : Integer;
 begin
 
-  raise ENotImplemented.Create('Please implement your solution.'); result := length(AArray) * Avalue;
+  raise ENotImplemented.Create('Please implement your solution.'); result := Round(length(AArray) * Avalue);
 
 end;
 

exercises/practice/binary-search/TestCases.pas

@@ -16,8 +16,8 @@   BinarySearchTest = class(TTestCase)
     procedure finds_a_value_in_an_array_of_odd_length;
     procedure finds_a_value_in_an_array_of_even_length;
     procedure identifies_that_a_value_is_not_included_in_the_array;
-    procedure a_value_smaller_than_the_array_s_smallest_value_is_not_found;
-    procedure a_value_larger_than_the_array_s_largest_value_is_not_found;
+    procedure a_value_smaller_than_the_arrays_smallest_value_is_not_found;
+    procedure a_value_larger_than_the_arrays_largest_value_is_not_found;
     procedure nothing_is_found_in_an_empty_array;
     procedure nothing_is_found_when_the_left_and_right_bounds_cross;
   end;
@@ -30,8 +30,8 @@ procedure TapAssertExpectionMessage(
   ACase          : TTestCase ;
   const AMessage : string    ;
   const Expected : string    ;
-  const AArray   : TIntArray ;
-  const AValue   : integer
+  const AArray   : TExtendedArray ;
+  const AValue   : Extended
 );
 var
   JsonMsg : string;
@@ -49,68 +49,101 @@ procedure TapAssertExpectionMessage(
 
 // b55c24a9-a98d-4379-a08c-2adcf8ebeee8
 procedure BinarySearchTest.finds_a_value_in_an_array_with_one_element;
+const
+  haystack : TExtendedArray = (6);
+  needle : Extended = 6;
 begin
-  TapAssertTrue(Self, 'finds a value in an array with one element', 0, BinarySearch.find([6], 6));
+  TapAssertTrue(Self, 'finds a value in an array with one element', 0, BinarySearch.find(haystack, needle));
 end;
 
 // 73469346-b0a0-4011-89bf-989e443d503d
 procedure BinarySearchTest.finds_a_value_in_the_middle_of_an_array;
+const
+  haystack : TExtendedArray = (1, 3, 4, 6, 8, 9, 11);
+  needle : Extended = 6;
 begin
-  TapAssertTrue(Self, 'finds a value in the middle of an array', 3, BinarySearch.find([1,3,4,6,8,9,11], 6));
+  TapAssertTrue(Self, 'finds a value in the middle of an array', 3, BinarySearch.find(haystack, needle));
 end;
 
 // 327bc482-ab85-424e-a724-fb4658e66ddb
 procedure BinarySearchTest.finds_a_value_at_the_beginning_of_an_array;
+const
+  haystack : TExtendedArray = (1, 3, 4, 6, 8, 9, 11);
+  needle : Extended = 1;
 begin
-  TapAssertTrue(Self, 'finds a value at the beginning of an array', 0, BinarySearch.find([1,3,4,6,8,9,11], 1));
+  TapAssertTrue(Self, 'finds a value at the beginning of an array', 0, BinarySearch.find(haystack, needle));
 end;
 
 // f9f94b16-fe5e-472c-85ea-c513804c7d59
 procedure BinarySearchTest.finds_a_value_at_the_end_of_an_array;
+const
+  haystack : TExtendedArray = (1, 3, 4, 6, 8, 9, 11);
+  needle : Extended = 11;
 begin
-  TapAssertTrue(Self, 'finds a value at the end of an array', 6, BinarySearch.find([1,3,4,6,8,9,11], 11));
+  TapAssertTrue(Self, 'finds a value at the end of an array', 6, BinarySearch.find(haystack, needle));
 end;
 
 // f0068905-26e3-4342-856d-ad153cadb338
 procedure BinarySearchTest.finds_a_value_in_an_array_of_odd_length;
+const
+  haystack : TExtendedArray = (1, 3, 5, 8, 13, 21, 34, 55, 89, 144, 233, 377, 634);
+  needle : Extended = 144;
 begin
-  TapAssertTrue(Self, 'finds a value in an array of odd length', 9, BinarySearch.find([1,3,5,8,13,21,34,55,89,144,233,377,634], 144));
+  TapAssertTrue(Self, 'finds a value in an array of odd length', 9, BinarySearch.find(haystack, needle));
 end;
 
 // fc316b12-c8b3-4f5e-9e89-532b3389de8c
 procedure BinarySearchTest.finds_a_value_in_an_array_of_even_length;
+const
+  haystack : TExtendedArray = (1, 3, 5, 8, 13, 21, 34, 55, 89, 144, 233, 377);
+  needle : Extended = 21;
 begin
-  TapAssertTrue(Self, 'finds a value in an array of even length', 5, BinarySearch.find([1,3,5,8,13,21,34,55,89,144,233,377], 21));
+  TapAssertTrue(Self, 'finds a value in an array of even length', 5, BinarySearch.find(haystack, needle));
 end;
 
 // da7db20a-354f-49f7-a6a1-650a54998aa6
 procedure BinarySearchTest.identifies_that_a_value_is_not_included_in_the_array;
+const
+  haystack : TExtendedArray = (1, 3, 4, 6, 8, 9, 11);
+  needle : Extended = 7;
 begin
-  TapAssertExpectionMessage(Self, 'identifies that a value is not included in the array', 'value not in array', [1,3,4,6,8,9,11], 7);
+  TapAssertExpectionMessage(Self, 'identifies that a value is not included in the array', 'value not in array', haystack, needle);
 end;
 
 // 95d869ff-3daf-4c79-b622-6e805c675f97
-procedure BinarySearchTest.a_value_smaller_than_the_array_s_smallest_value_is_not_found;
+procedure BinarySearchTest.a_value_smaller_than_the_arrays_smallest_value_is_not_found;
+const
+  haystack : TExtendedArray = (1, 3, 4, 6, 8, 9, 11);
+  needle : Extended = 0;
 begin
-  TapAssertExpectionMessage(Self, 'a value smaller than the array''s smallest value is not found', 'value not in array', [1,3,4,6,8,9,11], 0);
+  TapAssertExpectionMessage(Self, 'a value smaller than the arrays smallest value is not found', 'value not in array', haystack, needle);
 end;
 
 // 8b24ef45-6e51-4a94-9eac-c2bf38fdb0ba
-procedure BinarySearchTest.a_value_larger_than_the_array_s_largest_value_is_not_found;
+procedure BinarySearchTest.a_value_larger_than_the_arrays_largest_value_is_not_found;
+const
+  haystack : TExtendedArray = (1, 3, 4, 6, 8, 9, 11);
+  needle : Extended = 13;
 begin
-  TapAssertExpectionMessage(Self, 'a value larger than the array''s largest value is not found', 'value not in array', [1,3,4,6,8,9,11], 13);
+  TapAssertExpectionMessage(Self, 'a value larger than the arrays largest value is not found', 'value not in array', haystack, needle);
 end;
 
 // f439a0fa-cf42-4262-8ad1-64bf41ce566a
 procedure BinarySearchTest.nothing_is_found_in_an_empty_array;
+const
+  haystack : TExtendedArray = ();
+  needle : Extended = 1;
 begin
-  TapAssertExpectionMessage(Self, 'nothing is found in an empty array', 'value not in array', [], 1);
+  TapAssertExpectionMessage(Self, 'nothing is found in an empty array', 'value not in array', haystack, needle);
 end;
 
 // 2c353967-b56d-40b8-acff-ce43115eed64
 procedure BinarySearchTest.nothing_is_found_when_the_left_and_right_bounds_cross;
+const
+  haystack : TExtendedArray = (1, 2);
+  needle : Extended = 0;
 begin
-  TapAssertExpectionMessage(Self, 'nothing is found when the left and right bounds cross', 'value not in array', [1,2], 0);
+  TapAssertExpectionMessage(Self, 'nothing is found when the left and right bounds cross', 'value not in array', haystack, needle);
 end;
 
 initialization