Skip to content

Commit b68b3f5

Browse files
Don't treat warnings as errors (#278)
1 parent 92304ac commit b68b3f5

File tree

5 files changed

+48
-1
lines changed

5 files changed

+48
-1
lines changed

src/Exercism.TestRunner.FSharp/Testing.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ module DotnetCli =
258258
let solutionDir = Path.GetDirectoryName(context.TestsFile)
259259

260260
Process.exec "dotnet" "restore --source /root/.nuget/packages/" solutionDir
261-
Process.exec "dotnet" $"test --no-restore --verbosity=quiet --logger \"trx;LogFileName=%s{Path.GetFileName(context.TestResultsFile)}\" /flp:v=q" solutionDir
261+
Process.exec "dotnet" $"test --no-restore --verbosity=quiet --logger \"trx;LogFileName=%s{Path.GetFileName(context.TestResultsFile)}\" /flp:verbosity=quiet;errorsOnly=true" solutionDir
262262

263263
let buildErrors = parseBuildErrors context
264264

tests/Warnings/Warnings.fs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
module SingleTestThatPasses
2+
3+
let add x y =
4+
match true with
5+
| true -> x + y

tests/Warnings/Warnings.fsproj

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
<Project Sdk="Microsoft.NET.Sdk">
2+
3+
<PropertyGroup>
4+
<TargetFramework>net8.0</TargetFramework>
5+
6+
<IsPackable>false</IsPackable>
7+
</PropertyGroup>
8+
9+
<ItemGroup>
10+
<Compile Include="Warnings.fs" />
11+
<Compile Include="WarningsTests.fs" />
12+
</ItemGroup>
13+
14+
<ItemGroup>
15+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
16+
<PackageReference Include="xunit" Version="2.4.1" />
17+
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" />
18+
<PackageReference Include="FsUnit.xUnit" Version="4.0.4" />
19+
<PackageReference Include="Exercism.Tests" Version="0.1.0-alpha" />
20+
</ItemGroup>
21+
22+
</Project>

tests/Warnings/WarningsTests.fs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
module SingleTestThatPassesTests
2+
3+
open Xunit
4+
open FsUnit.Xunit
5+
open Exercism.Tests
6+
open SingleTestThatPasses
7+
8+
[<Fact>]
9+
let ``Add should add numbers`` () = add 1 1 |> should equal 2

tests/Warnings/expected_results.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"version": 3,
3+
"status": "pass",
4+
"tests": [
5+
{
6+
"name": "Add should add numbers",
7+
"status": "pass",
8+
"test_code": "add 1 1 |\u003E should equal 2"
9+
}
10+
]
11+
}

0 commit comments

Comments
 (0)