Merge branch 'main' into add-approach-bob

Author: jagdish-15

.github/workflows/markdown.yml

@@ -19,4 +19,4 @@ jobs:
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - name: Lint markdown
-        uses: DavidAnson/markdownlint-cli2-action@db43aef879112c3119a410d69f66701e0d530809
+        uses: DavidAnson/markdownlint-cli2-action@eb5ca3ab411449c66620fe7f1b3c9e10547144b0

exercises/practice/binary-search/src/test/java/BinarySearchTest.java

@@ -94,7 +94,7 @@ public void aValueSmallerThanTheArraysSmallestValueIsNotFound() {
 
     @Disabled("Remove to run test")
     @Test
-    public void aValueLargerThanTheArraysSmallestValueIsNotFound() throws ValueNotFoundException {
+    public void aValueLargerThanTheArraysLargestValueIsNotFound() throws ValueNotFoundException {
         List<Integer> sortedList = List.of(1, 3, 4, 6, 8, 9, 11);
 
         BinarySearch search = new BinarySearch(sortedList);

exercises/practice/darts/.approaches/introduction.md

@@ -39,19 +39,19 @@ import java.util.function.DoublePredicate;
 
 class Darts {
 
-    final private static double innerRing = 1.0;
-    final private static double middleRing = 5.0;
-    final private static double outerRing = 10.0;
+    private static final double INNER_RING = 1.0;
+    private static final double MIDDLE_RING = 5.0;
+    private static final double OUTER_RING = 10.0;
 
     int score(double x, double y) {
         var pointRadius = (Math.sqrt((x * x) + (y * y)));
         DoublePredicate thrownOutside = ring -> pointRadius > ring;
 
-        if (thrownOutside.test(outerRing))
+        if (thrownOutside.test(OUTER_RING))
             return 0;
-        if (thrownOutside.test(middleRing))
+        if (thrownOutside.test(MIDDLE_RING))
             return 1;
-        if (thrownOutside.test(innerRing))
+        if (thrownOutside.test(INNER_RING))
             return 5;
         return 10;
     }

exercises/practice/palindrome-products/.meta/config.json

@@ -4,6 +4,7 @@
   ],
   "contributors": [
     "FridaTveit",
+    "jagdish-15",
     "jmrunkle",
     "jssander",
     "kytrinyx",

exercises/practice/palindrome-products/.meta/tests.toml

@@ -1,12 +1,19 @@
-# This is an auto-generated file. Regular comments will be removed when this
-# file is regenerated. Regenerating will not touch any manually added keys,
-# so comments can be added in a "comment" key.
+# This is an auto-generated file.
+#
+# Regenerating this file via `configlet sync` will:
+# - Recreate every `description` key/value pair
+# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications
+# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion)
+# - Preserve any other key/value pair
+#
+# As user-added comments (using the # character) will be removed when this file
+# is regenerated, comments can be added via a `comment` key.
 
 [5cff78fe-cf02-459d-85c2-ce584679f887]
-description = "finds the smallest palindrome from single digit factors"
+description = "find the smallest palindrome from single digit factors"
 
 [0853f82c-5fc4-44ae-be38-fadb2cced92d]
-description = "finds the largest palindrome from single digit factors"
+description = "find the largest palindrome from single digit factors"
 
 [66c3b496-bdec-4103-9129-3fcb5a9063e1]
 description = "find the smallest palindrome from double digit factors"
@@ -15,13 +22,13 @@ description = "find the smallest palindrome from double digit factors"
 description = "find the largest palindrome from double digit factors"
 
 [cecb5a35-46d1-4666-9719-fa2c3af7499d]
-description = "find smallest palindrome from triple digit factors"
+description = "find the smallest palindrome from triple digit factors"
 
 [edab43e1-c35f-4ea3-8c55-2f31dddd92e5]
 description = "find the largest palindrome from triple digit factors"
 
 [4f802b5a-9d74-4026-a70f-b53ff9234e4e]
-description = "find smallest palindrome from four digit factors"
+description = "find the smallest palindrome from four digit factors"
 
 [787525e0-a5f9-40f3-8cb2-23b52cf5d0be]
 description = "find the largest palindrome from four digit factors"
@@ -37,3 +44,6 @@ description = "error result for smallest if min is more than max"
 
 [eeeb5bff-3f47-4b1e-892f-05829277bd74]
 description = "error result for largest if min is more than max"
+
+[16481711-26c4-42e0-9180-e2e4e8b29c23]
+description = "smallest product does not use the smallest factor"

exercises/practice/palindrome-products/src/test/java/PalindromeCalculatorTest.java

@@ -176,6 +176,22 @@ public void errorLargestMinIsMoreThanMax() {
                 .withMessage("invalid input: min must be <= max");
     }
 
+    @Disabled("Remove to run test")
+    @Test
+    public void smallestProductDoesNotUseTheSmallestFactor() {
+        List<List<Integer>> expected = Collections.unmodifiableList(
+                Arrays.asList(
+                        Arrays.asList(3297, 3333)
+                )
+        );
+        long expectedValue = 10988901L;
+
+        SortedMap<Long, List<List<Integer>>> palindromes = palindromeCalculator.getPalindromeProductsWithFactors(3215,
+                4000);
+
+        checkPalindromeWithFactorsMatchesExpected(expected, expectedValue, palindromes, palindromes.firstKey());
+    }
+
 
     private void checkPalindromeWithFactorsMatchesExpected(List<List<Integer>> expectedPalindromeFactors,
                                                            long expectedValueOfPalindrome,

exercises/practice/poker/.meta/config.json

@@ -6,10 +6,12 @@
     "aadityakulkarni",
     "FridaTveit",
     "hgvanpariya",
+    "jagdish-15",
     "jmrunkle",
     "katmpatz",
     "kytrinyx",
     "lemoncurry",
+    "MartinDekanovsky",
     "mirkoperillo",
     "msomji",
     "muzimuzhi",
@@ -27,8 +29,6 @@
       "src/test/java/PokerTest.java"
     ],
     "example": [
-      ".meta/src/reference/java/Card.java",
-      ".meta/src/reference/java/Hand.java",
       ".meta/src/reference/java/Poker.java"
     ],
     "invalidator": [