Skip to content

Commit b382016

Browse files
Merge branch 'main' into issue-2971-display-names
2 parents 7b1165b + 8419c95 commit b382016

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

exercises/practice/largest-series-product/.meta/config.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
"Smarticles101",
2323
"sonapraneeth-a",
2424
"sshine",
25+
"Xinri",
2526
"Zaldrick"
2627
],
2728
"files": {

exercises/practice/largest-series-product/.meta/tests.toml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,11 @@ description = "reports zero if all spans include zero"
3838

3939
[5d81aaf7-4f67-4125-bf33-11493cc7eab7]
4040
description = "rejects span longer than string length"
41+
include = false
42+
43+
[0ae1ce53-d9ba-41bb-827f-2fceb64f058b]
44+
description = "rejects span longer than string length"
45+
reimplements = "5d81aaf7-4f67-4125-bf33-11493cc7eab7"
4146

4247
[06bc8b90-0c51-4c54-ac22-3ec3893a079e]
4348
description = "reports 1 for empty string and empty product (0 span)"
@@ -49,6 +54,11 @@ include = false
4954

5055
[6d96c691-4374-4404-80ee-2ea8f3613dd4]
5156
description = "rejects empty string and nonzero span"
57+
include = false
58+
59+
[6cf66098-a6af-4223-aab1-26aeeefc7402]
60+
description = "rejects empty string and nonzero span"
61+
reimplements = "6d96c691-4374-4404-80ee-2ea8f3613dd4"
5262

5363
[7a38f2d6-3c35-45f6-8d6f-12e6e32d4d74]
5464
description = "rejects invalid character in digits"

exercises/practice/largest-series-product/src/test/java/LargestSeriesProductCalculatorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,8 @@ public void testSeriesLengthLongerThanLengthOfStringToTestIsRejected() {
129129

130130
@Disabled("Remove to run test")
131131
@Test
132-
@DisplayName("reports 1 for empty string and empty product (0 span)")
133-
public void testEmptyStringToSearchAndSeriesOfNonZeroLengthIsRejected() {
132+
@DisplayName("rejects empty string and nonzero span")
133+
public void testEmptyStringAndNonZeroSpanIsRejected() {
134134
LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator("");
135135

136136
assertThatExceptionOfType(IllegalArgumentException.class)

0 commit comments

Comments
 (0)