Skip to content

Commit bc73b1f

Browse files
authored
Apply suggestion from @jagdish-15
1 parent 13984bf commit bc73b1f

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

exercises/practice/secret-handshake/src/test/java/HandshakeCalculatorTest.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,32 @@ public void testThatHandlesMoreThanFiveBinaryPlacesWithoutReversal() {
107107
public void testInputThatYieldsAllActionsFromMoreThanFiveBinaryPlaces() {
108108
assertThat(handshakeCalculator.calculateHandshake(111))
109109
.containsExactly(Signal.WINK, Signal.DOUBLE_BLINK, Signal.CLOSE_YOUR_EYES, Signal.JUMP);
110+
/* The following tests diverge from the canonical test data to test numbers with binary representation with
111+
* more than five digits are correctly handled. For more details, check out issue #1965 here:
112+
* (https://github.com/exercism/java/issues/1965).
113+
*/
114+
@Disabled("Remove to run test")
115+
@Test
116+
@DisplayName("handles input with more than five bits with reversal")
117+
public void testThatHandlesMoreThanFiveBinaryPlacesWithReversal() {
118+
assertThat(handshakeCalculator.calculateHandshake(51))
119+
.containsExactly(Signal.DOUBLE_BLINK, Signal.WINK);
120+
}
121+
122+
@Disabled("Remove to run test")
123+
@Test
124+
@DisplayName("handles input with more than five bits without reversal")
125+
public void testThatHandlesMoreThanFiveBinaryPlacesWithoutReversal() {
126+
assertThat(handshakeCalculator.calculateHandshake(35))
127+
.containsExactly(Signal.WINK, Signal.DOUBLE_BLINK);
128+
}
129+
130+
@Disabled("Remove to run test")
131+
@Test
132+
@DisplayName("all actions for input with more than five bits")
133+
public void testInputThatYieldsAllActionsFromMoreThanFiveBinaryPlaces() {
134+
assertThat(handshakeCalculator.calculateHandshake(111))
135+
.containsExactly(Signal.WINK, Signal.DOUBLE_BLINK, Signal.CLOSE_YOUR_EYES, Signal.JUMP);
110136
}
111137

112138
}

0 commit comments

Comments
 (0)