From 2a74ff4cf40d9c7eed7b8af94bf9f952ff60234e Mon Sep 17 00:00:00 2001 From: xinri Date: Sun, 16 Nov 2025 23:44:26 +0100 Subject: [PATCH 1/2] sync the largest-series-product tests as they had been reimplemented but not sync --- .../practice/largest-series-product/.meta/tests.toml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/exercises/practice/largest-series-product/.meta/tests.toml b/exercises/practice/largest-series-product/.meta/tests.toml index 883169259..982f517cc 100644 --- a/exercises/practice/largest-series-product/.meta/tests.toml +++ b/exercises/practice/largest-series-product/.meta/tests.toml @@ -38,6 +38,11 @@ description = "reports zero if all spans include zero" [5d81aaf7-4f67-4125-bf33-11493cc7eab7] description = "rejects span longer than string length" +include = false + +[0ae1ce53-d9ba-41bb-827f-2fceb64f058b] +description = "rejects span longer than string length" +reimplements = "5d81aaf7-4f67-4125-bf33-11493cc7eab7" [06bc8b90-0c51-4c54-ac22-3ec3893a079e] description = "reports 1 for empty string and empty product (0 span)" @@ -49,6 +54,11 @@ include = false [6d96c691-4374-4404-80ee-2ea8f3613dd4] description = "rejects empty string and nonzero span" +include = false + +[6cf66098-a6af-4223-aab1-26aeeefc7402] +description = "rejects empty string and nonzero span" +reimplements = "6d96c691-4374-4404-80ee-2ea8f3613dd4" [7a38f2d6-3c35-45f6-8d6f-12e6e32d4d74] description = "rejects invalid character in digits" From 989dcfa4b1c2aaa4631eae4936aaadaf5a44da74 Mon Sep 17 00:00:00 2001 From: xinri Date: Mon, 17 Nov 2025 22:41:03 +0100 Subject: [PATCH 2/2] reimplement and fix unit tests in the largest series product feature Signed-off-by: xinri --- exercises/practice/largest-series-product/.meta/config.json | 1 + .../src/test/java/LargestSeriesProductCalculatorTest.java | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/exercises/practice/largest-series-product/.meta/config.json b/exercises/practice/largest-series-product/.meta/config.json index b6a57ee6c..c3ba23a98 100644 --- a/exercises/practice/largest-series-product/.meta/config.json +++ b/exercises/practice/largest-series-product/.meta/config.json @@ -22,6 +22,7 @@ "Smarticles101", "sonapraneeth-a", "sshine", + "Xinri", "Zaldrick" ], "files": { diff --git a/exercises/practice/largest-series-product/src/test/java/LargestSeriesProductCalculatorTest.java b/exercises/practice/largest-series-product/src/test/java/LargestSeriesProductCalculatorTest.java index 8a2c48e20..417878d1e 100644 --- a/exercises/practice/largest-series-product/src/test/java/LargestSeriesProductCalculatorTest.java +++ b/exercises/practice/largest-series-product/src/test/java/LargestSeriesProductCalculatorTest.java @@ -129,8 +129,8 @@ public void testSeriesLengthLongerThanLengthOfStringToTestIsRejected() { @Disabled("Remove to run test") @Test - @DisplayName("reports 1 for empty string and empty product (0 span)") - public void testEmptyStringToSearchAndSeriesOfNonZeroLengthIsRejected() { + @DisplayName("rejects empty string and nonzero span") + public void testEmptyStringAndNonZeroSpanIsRejected() { LargestSeriesProductCalculator calculator = new LargestSeriesProductCalculator(""); assertThatExceptionOfType(IllegalArgumentException.class)