Skip to content

Commit 1de010d

Browse files
Modified tests in captains-log.spec.js
1 parent 5ba9ac2 commit 1de010d

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

exercises/concept/captains-log/captains-log.spec.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,19 @@ import { describe, expect, test } from '@jest/globals';
22
import { randomShipRegistryNumber, randomStardate, randomPlanetClass } from './captains-log';
33
describe('randomShipRegistryNumber',() => {
44
test('registry numbers are valid',() => {
5-
expect(randomShipRegistryNumber().test(/NCC-[1-9][0-9]{3}/)).toBe(true);
6-
expect(randomShipRegistryNumber().test(/NCC-[1-9][0-9]{3}/)).toBe(true);
7-
expect(randomShipRegistryNumber().test(/NCC-[1-9][0-9]{3}/)).toBe(true);
5+
for (let i=0;i<4; i++){
6+
expect(randomShipRegistryNumber()).toMatch(/NCC-[1-9][0-9]{3}/))
7+
}
88
});
99
test('returns a random registry number',() => {
1010
expect(randomShipRegistryNumber()).not.toEqual(randomShipRegistryNumber())
1111
});
1212
});
1313
describe('randomStardate',() => {
1414
test('stardates are valid',() => {
15-
expect(41000<=randomStardate()<42000).toBe(true);
16-
expect(41000<=randomStardate()<42000).toBe(true);
17-
expect(41000<=randomStardate()<42000).toBe(true);
15+
for (let i=0;i<4; i++){
16+
expect(randomStardate()>=41000 && randomStardate()<42000).toBe(true);
17+
}
1818
});
1919
test('returns a random stardate',() => {
2020
expect(randomStardate()).not.toEqual(randomStardate())
@@ -23,9 +23,9 @@ describe('randomStardate',() => {
2323
describe('randomPlanetClass', () => {
2424
test('planet classes are valid', () => {
2525
const planetClasses = ['D', 'H', 'J', 'K', 'L', 'M', 'N', 'R', 'T', 'Y'];
26-
expect(planetClasses.includes(randomPlanetClass())).toBe(true)
27-
expect(planetClasses.includes(randomPlanetClass())).toBe(true)
28-
expect(planetClasses.includes(randomPlanetClass())).toBe(true)
26+
for (let i=0;i<4; i++){
27+
expect(planetClasses.includes(randomPlanetClass())).toBe(true)
28+
}
2929
});
3030
test('returns a random planet class',() => {
3131
expect(randomPlanetClass()).not.toEqual(randomPlanetClass())

0 commit comments

Comments
 (0)