Skip to content

Commit 383306a

Browse files
authored
Syncing test.toml and updating the test code for largest-series-product (#2647)
[no important files changed]
1 parent 5e1e05e commit 383306a

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

exercises/practice/largest-series-product/.meta/proof.ci.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ export const largestProduct = (digits, seriesLength) => {
33
return 1;
44
}
55
if (seriesLength > digits.length) {
6-
throw new Error('span must be smaller than string length');
6+
throw new Error('span must not exceed string length');
77
}
88
if (seriesLength < 0) {
99
throw new Error('span must not be negative');

exercises/practice/largest-series-product/.meta/tests.toml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,11 @@ description = "reports zero if all spans include zero"
3838

3939
[5d81aaf7-4f67-4125-bf33-11493cc7eab7]
4040
description = "rejects span longer than string length"
41+
include = false
42+
43+
[0ae1ce53-d9ba-41bb-827f-2fceb64f058b]
44+
description = "rejects span longer than string length"
45+
reimplements = "5d81aaf7-4f67-4125-bf33-11493cc7eab7"
4146

4247
[06bc8b90-0c51-4c54-ac22-3ec3893a079e]
4348
description = "reports 1 for empty string and empty product (0 span)"
@@ -49,6 +54,11 @@ include = false
4954

5055
[6d96c691-4374-4404-80ee-2ea8f3613dd4]
5156
description = "rejects empty string and nonzero span"
57+
include = false
58+
59+
[6cf66098-a6af-4223-aab1-26aeeefc7402]
60+
description = "rejects empty string and nonzero span"
61+
reimplements = "6d96c691-4374-4404-80ee-2ea8f3613dd4"
5262

5363
[7a38f2d6-3c35-45f6-8d6f-12e6e32d4d74]
5464
description = "rejects invalid character in digits"

exercises/practice/largest-series-product/largest-series-product.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ describe('Largest Series Product', () => {
4242

4343
xtest('rejects span longer than string length', () => {
4444
expect(() => largestProduct('123', 4)).toThrow(
45-
new Error('span must be smaller than string length'),
45+
new Error('span must not exceed string length'),
4646
);
4747
});
4848

4949
xtest('rejects empty string and nonzero span', () => {
5050
expect(() => largestProduct('', 1)).toThrow(
51-
new Error('span must be smaller than string length'),
51+
new Error('span must not exceed string length'),
5252
);
5353
});
5454

0 commit comments

Comments
 (0)