Fix cleanups

Author: SleeplessByte

reference/implementing-a-concept-exercise.md

@@ -55,7 +55,7 @@ github/exercism
                 ├── <slug>.js
                 ├── <slug>.spec.js
                 ├── package.json
-                └── yarn.lock
+                └── pnpm-lock.yaml
 </pre>
 
 ## Step 1: Add code files
@@ -70,7 +70,7 @@ The configuration files may be copied from another exercise. We aim to keep thes
 - `eslint.config.mjs`
 - `jest.config.js`
 - `package.json`
-- `yarn.lock`
+- `pnpm-lock.yaml`
 
 The `package.json` file must be edited:
 

scripts/ci-check.mjs

@@ -36,7 +36,7 @@ if (exercises.length === 1) {
   }
 }
 
-registerExitHandler();
+registerExitHandler(false);
 
 if (!envIsThruthy('SKIP_STUB', false)) {
   echo('\n==========\nEnsure stubs are present\n');

scripts/ci.mjs

@@ -29,7 +29,7 @@ if (exercises.length === 0) {
   exit(0);
 }
 
-registerExitHandler();
+registerExitHandler(false);
 
 env['PREPARE'] = false;
 env['CLEANUP'] = false;

scripts/helpers.mjs

@@ -186,9 +186,9 @@ export function createExercisePackageJson(writeSha = false) {
   const packageJson = JSON.parse(packageFile);
 
   // Filter out some unwanted packages and create package.json for exercises
-  SKIP_PACKAGES_FOR_CHECKSUM.forEach(
-    (pkg) => delete packageJson['devDependencies'][pkg],
-  );
+  SKIP_PACKAGES_FOR_CHECKSUM.forEach((pkg) => {
+    delete packageJson['devDependencies'][pkg];
+  });
 
   const shellStr = new shell.ShellString(
     JSON.stringify(packageJson, undefined, 2) + '\n',
@@ -375,9 +375,9 @@ export function prepare(assignment) {
   }
 }
 
-export function registerExitHandler() {
+export function registerExitHandler(forceCleanup = true) {
   function exitHandler(options, exitCode) {
-    if (shouldCleanup()) {
+    if (shouldCleanup() || forceCleanup) {
       cleanUp();
     }
 

scripts/lint.mjs

@@ -17,7 +17,7 @@ import {
   shouldPrepare,
 } from './helpers.mjs';
 
-registerExitHandler();
+registerExitHandler(false);
 
 const assignment = exercises.length === 0 ? exercises[0] : undefined;
 

scripts/pr-check.mjs

@@ -64,7 +64,7 @@ if (exercises.length === 0) {
   shell.exit(0);
 }
 
-registerExitHandler();
+registerExitHandler(false);
 
 if (!envIsThruthy('SKIP_STUB', false)) {
   shell.echo('\n==========\nEnsure stubs are present\n');
@@ -75,7 +75,9 @@ if (!envIsThruthy('SKIP_STUB', false)) {
 
   if (noStubs.length > 0) {
     shell.echo(`[FAILURE] ${noStubs.length} missing a stub`);
-    noStubs.forEach((stub) => shell.echo(`${stub} is missing a stub file`));
+    noStubs.forEach((stub) => {
+      shell.echo(`${stub} is missing a stub file`);
+    });
     shell.exit(-1);
   } else {
     shell.echo('[SUCCES] All stubs are present');

scripts/pr.mjs

@@ -61,7 +61,7 @@ if (exercises.length === 0) {
   shell.exit(0);
 }
 
-registerExitHandler();
+registerExitHandler(false);
 
 shell.env['PREPARE'] = false;
 shell.env['CLEANUP'] = false;

scripts/sync.mjs

@@ -3,15 +3,9 @@
 /**
  * Run this script (from root directory):
  *
- * $ corepack yarn sync
+ * $ corepack pnpm scripts/sync.mjs
  *
- * This script is used to copy the following files to all exercises and keep
- * them in sync:
- *
- * - .eslintrc
- * - babel.config.js
- * - package.json (modified version)
- * - .npmrc
+ * This script is used to copy the required files.
  *
  * There is a CI step which checks that package.json in root & exercises match
  * (see checksum script for more info).