From 3be0fc0450a6899ba92c158cc027b568ed92f856 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Mon, 6 Jan 2025 00:57:30 +0530 Subject: [PATCH 1/2] Updating tests collatz-conjecture --- .../collatz-conjecture/.meta/config.json | 1 + .../collatz-conjecture/.meta/tests.toml | 23 ++++++++++++++++--- .../collatz-conjecture.spec.js | 4 ++-- 3 files changed, 23 insertions(+), 5 deletions(-) diff --git a/exercises/practice/collatz-conjecture/.meta/config.json b/exercises/practice/collatz-conjecture/.meta/config.json index 416c098eb1..bcde7be429 100644 --- a/exercises/practice/collatz-conjecture/.meta/config.json +++ b/exercises/practice/collatz-conjecture/.meta/config.json @@ -2,6 +2,7 @@ "authors": [], "contributors": [ "ankorGH", + "jagdish-15", "rchavarria", "SleeplessByte", "xarxziux" diff --git a/exercises/practice/collatz-conjecture/.meta/tests.toml b/exercises/practice/collatz-conjecture/.meta/tests.toml index 04187f605c..cc34e16847 100644 --- a/exercises/practice/collatz-conjecture/.meta/tests.toml +++ b/exercises/practice/collatz-conjecture/.meta/tests.toml @@ -1,6 +1,13 @@ -# This is an auto-generated file. Regular comments will be removed when this -# file is regenerated. Regenerating will not touch any manually added keys, -# so comments can be added in a "comment" key. +# This is an auto-generated file. +# +# Regenerating this file via `configlet sync` will: +# - Recreate every `description` key/value pair +# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications +# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion) +# - Preserve any other key/value pair +# +# As user-added comments (using the # character) will be removed when this file +# is regenerated, comments can be added via a `comment` key. [540a3d51-e7a6-47a5-92a3-4ad1838f0bfd] description = "zero steps for one" @@ -16,6 +23,16 @@ description = "large number of even and odd steps" [7d4750e6-def9-4b86-aec7-9f7eb44f95a3] description = "zero is an error" +include = false + +[2187673d-77d6-4543-975e-66df6c50e2da] +description = "zero is an error" +reimplements = "7d4750e6-def9-4b86-aec7-9f7eb44f95a3" [c6c795bf-a288-45e9-86a1-841359ad426d] description = "negative value is an error" +include = false + +[ec11f479-56bc-47fd-a434-bcd7a31a7a2e] +description = "negative value is an error" +reimplements = "c6c795bf-a288-45e9-86a1-841359ad426d" diff --git a/exercises/practice/collatz-conjecture/collatz-conjecture.spec.js b/exercises/practice/collatz-conjecture/collatz-conjecture.spec.js index 0193280326..87714b9b4e 100644 --- a/exercises/practice/collatz-conjecture/collatz-conjecture.spec.js +++ b/exercises/practice/collatz-conjecture/collatz-conjecture.spec.js @@ -21,12 +21,12 @@ describe('steps()', () => { xtest('zero is an error', () => { expect(() => { steps(0); - }).toThrow(new Error('Only positive numbers are allowed')); + }).toThrow(new Error('Only positive integers are allowed')); }); xtest('negative value is an error', () => { expect(() => { steps(-15); - }).toThrow(new Error('Only positive numbers are allowed')); + }).toThrow(new Error('Only positive integers are allowed')); }); }); From 5257a8462a766f1b0fc867bb49775f495a2941e6 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Mon, 6 Jan 2025 01:00:27 +0530 Subject: [PATCH 2/2] updating proof.ci.js for collatz-conjecture --- exercises/practice/collatz-conjecture/.meta/proof.ci.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/collatz-conjecture/.meta/proof.ci.js b/exercises/practice/collatz-conjecture/.meta/proof.ci.js index ed0f95f494..6ebeeff93a 100644 --- a/exercises/practice/collatz-conjecture/.meta/proof.ci.js +++ b/exercises/practice/collatz-conjecture/.meta/proof.ci.js @@ -1,6 +1,6 @@ export const steps = (n) => { if (n <= 0) { - throw new Error('Only positive numbers are allowed'); + throw new Error('Only positive integers are allowed'); } const iterate = (number, step) => {