-
-
Notifications
You must be signed in to change notification settings - Fork 655
Add Concept Exercise for type checking. #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Still not done!
Create all the functions using typeof
Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
|
I've added you as an author, I feel that you have built a fair bit of the exercise. |
SleeplessByte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll batch submit these. Then publish, have some people solve it, and then I'll add some more tests. Thanks for this. It's another great one @quintuple-mallard !
|
I'll fix |
This PR adds the
assembly-lineexercise andtype-checkingconcept to the JavaScript track.A few notes/questions:
numbersconcept, but all slightly different. Does this matter?nodejsthat I haven't been able to fix has stopped me from running theformatscript. Configlet and the other node scripts have been working.Object.hasOwnrather thanObject.prototype.hasOwnProperty, as it seemsObject.hasOwnis the recommended overObject.prototype.hasOwnProperty, that is considered somewhat outdated.