-
-
Notifications
You must be signed in to change notification settings - Fork 656
test: constrict lower bounds and upper bounds of test case #2742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I recently mentored a solution where the mentee used `>=100` and it passed. I'm making this PR to fix that. Link to solution: https://exercism.org/mentoring/requests/dad84dead4344defb12e2788a142713b
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
@orimdominic Feel free to add your github username to the contributors list, if you want some rep. Good catch. (/format for the bot to wakeup) |
|
The "Format code" action has started running. |
|
The "Format code" action has finished running. |
|
For security reasons,
|
|
(closing and re-opening to force the CI to run) |
|
@orimdominic I'm assuming you don't want to be included as a contributor, so I'm merging this (will probably wait a little more but not more than a day) |
Please how do I add my name to the list? |
|
@orimdominic in the |
|
Done @Cool-Katt |
I recently mentored a solution where the mentee used
>=100and it passed. I'm making this PR to fix that.Link to solution: https://exercism.org/mentoring/requests/dad84dead4344defb12e2788a142713b