Sync queen-attack (#553)

* Sync queen-attack
* format

Author: keiravillekode

exercises/practice/queen-attack/.docs/instructions.md

@@ -8,18 +8,14 @@ A chessboard can be represented by an 8 by 8 array.
 
 So if you are told the white queen is at `c5` (zero-indexed at column 2, row 3) and the black queen at `f2` (zero-indexed at column 5, row 6), then you know that the set-up is like so:
 
-```text
-  a b c d e f g h
-8 _ _ _ _ _ _ _ _ 8
-7 _ _ _ _ _ _ _ _ 7
-6 _ _ _ _ _ _ _ _ 6
-5 _ _ W _ _ _ _ _ 5
-4 _ _ _ _ _ _ _ _ 4
-3 _ _ _ _ _ _ _ _ 3
-2 _ _ _ _ _ B _ _ 2
-1 _ _ _ _ _ _ _ _ 1
-  a b c d e f g h
-```
+![A chess board with two queens. Arrows emanating from the queen at c5 indicate possible directions of capture along file, rank and diagonal.](https://assets.exercism.org/images/exercises/queen-attack/queen-capture.svg)
 
 You are also able to answer whether the queens can attack each other.
 In this case, that answer would be yes, they can, because both pieces share a diagonal.
+
+## Credit
+
+The chessboard image was made by [habere-et-dispertire][habere-et-dispertire] using LaTeX and the [chessboard package][chessboard-package] by Ulrike Fischer.
+
+[habere-et-dispertire]: https://exercism.org/profiles/habere-et-dispertire
+[chessboard-package]: https://github.com/u-fischer/chessboard

exercises/practice/queen-attack/.meta/tests.toml

@@ -1,39 +1,49 @@
-# This is an auto-generated file. Regular comments will be removed when this
-# file is regenerated. Regenerating will not touch any manually added keys,
-# so comments can be added in a "comment" key.
+# This is an auto-generated file.
+#
+# Regenerating this file via `configlet sync` will:
+# - Recreate every `description` key/value pair
+# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications
+# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion)
+# - Preserve any other key/value pair
+#
+# As user-added comments (using the # character) will be removed when this file
+# is regenerated, comments can be added via a `comment` key.
 
 [3ac4f735-d36c-44c4-a3e2-316f79704203]
-description = "queen with a valid position"
+description = "Test creation of Queens with valid and invalid positions -> queen with a valid position"
 
 [4e812d5d-b974-4e38-9a6b-8e0492bfa7be]
-description = "queen must have positive row"
+description = "Test creation of Queens with valid and invalid positions -> queen must have positive row"
 
 [f07b7536-b66b-4f08-beb9-4d70d891d5c8]
-description = "queen must have row on board"
+description = "Test creation of Queens with valid and invalid positions -> queen must have row on board"
 
 [15a10794-36d9-4907-ae6b-e5a0d4c54ebe]
-description = "queen must have positive column"
+description = "Test creation of Queens with valid and invalid positions -> queen must have positive column"
 
 [6907762d-0e8a-4c38-87fb-12f2f65f0ce4]
-description = "queen must have column on board"
+description = "Test creation of Queens with valid and invalid positions -> queen must have column on board"
 
 [33ae4113-d237-42ee-bac1-e1e699c0c007]
-description = "can not attack"
+description = "Test the ability of one queen to attack another -> cannot attack"
 
 [eaa65540-ea7c-4152-8c21-003c7a68c914]
-description = "can attack on same row"
+description = "Test the ability of one queen to attack another -> can attack on same row"
 
 [bae6f609-2c0e-4154-af71-af82b7c31cea]
-description = "can attack on same column"
+description = "Test the ability of one queen to attack another -> can attack on same column"
 
 [0e1b4139-b90d-4562-bd58-dfa04f1746c7]
-description = "can attack on first diagonal"
+description = "Test the ability of one queen to attack another -> can attack on first diagonal"
 
 [ff9b7ed4-e4b6-401b-8d16-bc894d6d3dcd]
-description = "can attack on second diagonal"
+description = "Test the ability of one queen to attack another -> can attack on second diagonal"
 
 [0a71e605-6e28-4cc2-aa47-d20a2e71037a]
-description = "can attack on third diagonal"
+description = "Test the ability of one queen to attack another -> can attack on third diagonal"
 
 [0790b588-ae73-4f1f-a968-dd0b34f45f86]
-description = "can attack on fourth diagonal"
+description = "Test the ability of one queen to attack another -> can attack on fourth diagonal"
+
+[543f8fd4-2597-4aad-8d77-cbdab63619f8]
+description = "Test the ability of one queen to attack another -> cannot attack if falling diagonals are only the same when reflected across the longest falling diagonal"

exercises/practice/queen-attack/queen-attack_spec.lua

@@ -68,8 +68,15 @@ describe('queen-attack', function()
   end)
 
   it('can attack on fourth diagonal', function()
-    local q1 = Queen({ row = 2, column = 2 })
-    local q2 = Queen({ row = 5, column = 5 })
+    local q1 = Queen({ row = 1, column = 7 })
+    local q2 = Queen({ row = 0, column = 6 })
     assert.is_true(q1.can_attack(q2))
   end)
+
+  it('cannot attack if falling diagonals are only the same when reflected across the longest falling diagonal',
+     function()
+    local q1 = Queen({ row = 4, column = 1 })
+    local q2 = Queen({ row = 2, column = 5 })
+    assert.is_false(q1.can_attack(q2))
+  end)
 end)