Sync isbn-verifier tests (#539)

Author: keiravillekode

exercises/practice/isbn-verifier/.meta/spec_generator.lua

@@ -0,0 +1,9 @@
+return {
+  module_name = 'isbn_verifier',
+
+  generate_test = function(case)
+    local template = [[
+      assert.is_%s(isbn_verifier.valid('%s'))]]
+    return template:format(case.expected, case.input.isbn)
+  end
+}

exercises/practice/isbn-verifier/.meta/tests.toml

@@ -1,21 +1,31 @@
-# This is an auto-generated file. Regular comments will be removed when this
-# file is regenerated. Regenerating will not touch any manually added keys,
-# so comments can be added in a "comment" key.
+# This is an auto-generated file.
+#
+# Regenerating this file via `configlet sync` will:
+# - Recreate every `description` key/value pair
+# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications
+# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion)
+# - Preserve any other key/value pair
+#
+# As user-added comments (using the # character) will be removed when this file
+# is regenerated, comments can be added via a `comment` key.
 
 [0caa3eac-d2e3-4c29-8df8-b188bc8c9292]
-description = "valid isbn number"
+description = "valid isbn"
 
 [19f76b53-7c24-45f8-87b8-4604d0ccd248]
 description = "invalid isbn check digit"
 
 [4164bfee-fb0a-4a1c-9f70-64c6a1903dcd]
-description = "valid isbn number with a check digit of 10"
+description = "valid isbn with a check digit of 10"
 
 [3ed50db1-8982-4423-a993-93174a20825c]
 description = "check digit is a character other than X"
 
+[9416f4a5-fe01-4b61-a07b-eb75892ef562]
+description = "invalid check digit in isbn is not treated as zero"
+
 [c19ba0c4-014f-4dc3-a63f-ff9aefc9b5ec]
-description = "invalid character in isbn"
+description = "invalid character in isbn is not treated as zero"
 
 [28025280-2c39-4092-9719-f3234b89c627]
 description = "X is only valid as a check digit"
@@ -48,7 +58,10 @@ description = "empty isbn"
 description = "input is 9 characters"
 
 [ed6e8d1b-382c-4081-8326-8b772c581fec]
-description = "invalid characters are not ignored"
+description = "invalid characters are not ignored after checking length"
+
+[daad3e58-ce00-4395-8a8e-e3eded1cdc86]
+description = "invalid characters are not ignored before checking length"
 
 [fb5e48d8-7c03-4bfb-a088-b101df16fdc3]
 description = "input is too long but contains a valid isbn"

exercises/practice/isbn-verifier/isbn-verifier_spec.lua

@@ -1,55 +1,79 @@
-local valid = require('isbn-verifier').valid
+local isbn_verifier = require('isbn-verifier')
 
 describe('isbn-verifier', function()
-  it('valid isbn number', function()
-    assert.is_true(valid('3-598-21508-8'))
+  it('valid isbn', function()
+    assert.is_true(isbn_verifier.valid('3-598-21508-8'))
   end)
 
   it('invalid isbn check digit', function()
-    assert.is_false(valid('3-598-21508-9'))
+    assert.is_false(isbn_verifier.valid('3-598-21508-9'))
   end)
 
-  it('valid isbn number with a check digit of 10', function()
-    assert.is_true(valid('3-598-21507-X'))
+  it('valid isbn with a check digit of 10', function()
+    assert.is_true(isbn_verifier.valid('3-598-21507-X'))
   end)
 
-  it('check digit is a character other than X', function()
-    assert.is_false(valid('3-598-21507-A'))
+  it('check digit is a character other than x', function()
+    assert.is_false(isbn_verifier.valid('3-598-21507-A'))
   end)
 
-  it('invalid character in isbn', function()
-    assert.is_false(valid('3-598-2K507-0'))
+  it('invalid check digit in isbn is not treated as zero', function()
+    assert.is_false(isbn_verifier.valid('4-598-21507-B'))
   end)
 
-  it('X is only valid as a check digit', function()
-    assert.is_false(valid('3-598-2X507-9'))
+  it('invalid character in isbn is not treated as zero', function()
+    assert.is_false(isbn_verifier.valid('3-598-P1581-X'))
+  end)
+
+  it('x is only valid as a check digit', function()
+    assert.is_false(isbn_verifier.valid('3-598-2X507-9'))
   end)
 
   it('valid isbn without separating dashes', function()
-    assert.is_true(valid('3598215088'))
+    assert.is_true(isbn_verifier.valid('3598215088'))
   end)
 
-  it('isbn without separating dashes and X as check digit', function()
-    assert.is_true(valid('359821507X'))
+  it('isbn without separating dashes and x as check digit', function()
+    assert.is_true(isbn_verifier.valid('359821507X'))
   end)
 
   it('isbn without check digit and dashes', function()
-    assert.is_false(valid('359821507'))
+    assert.is_false(isbn_verifier.valid('359821507'))
   end)
 
   it('too long isbn and no dashes', function()
-    assert.is_false(valid('3598215078X'))
+    assert.is_false(isbn_verifier.valid('3598215078X'))
+  end)
+
+  it('too short isbn', function()
+    assert.is_false(isbn_verifier.valid('00'))
   end)
 
   it('isbn without check digit', function()
-    assert.is_false(valid('3-598-21507'))
+    assert.is_false(isbn_verifier.valid('3-598-21507'))
+  end)
+
+  it('check digit of x should not be used for 0', function()
+    assert.is_false(isbn_verifier.valid('3-598-21515-X'))
+  end)
+
+  it('empty isbn', function()
+    assert.is_false(isbn_verifier.valid(''))
+  end)
+
+  it('input is 9 characters', function()
+    assert.is_false(isbn_verifier.valid('134456729'))
+  end)
+
+  it('invalid characters are not ignored after checking length', function()
+    assert.is_false(isbn_verifier.valid('3132P34035'))
   end)
 
-  it('too long isbn', function()
-    assert.is_false(valid('3-598-21507-XX'))
+  it('invalid characters are not ignored before checking length', function()
+    assert.is_false(isbn_verifier.valid('3598P215088'))
   end)
 
-  it('check digit of X should not be used for 0', function()
-    assert.is_false(valid('3-598-21515-X'))
+  it('input is too long but contains a valid isbn', function()
+    assert.is_false(isbn_verifier.valid('98245726788'))
   end)
 end)