Update anagram tests (#578)

Author: ryanplusplus

exercises/practice/anagram/.meta/example.lua

@@ -9,7 +9,7 @@ local function alphagram(a_word)
   local str = a_word
   local t = {}
   for i = 1, #str do
-    t[i] = str:sub(i, i) -- string library sets metatable so can be accessed in object oriented style 
+    t[i] = str:sub(i, i) -- string library sets metatable so can be accessed in object oriented style
   end
   table.sort(t) -- sorts in place, no return value
   return table.concat(t, '')
@@ -19,9 +19,7 @@ function Anagram:match(list)
   local result = {}
   local t = list
   for i = 1, #t do
-    if (t[i]:lower() == self.word) then
-      table.insert(result, t[i])
-    elseif (alphagram(t[i]:lower()) == alphagram(self.word)) then
+    if (t[i]:lower() ~= self.word:lower()) and (alphagram(t[i]:lower()) == alphagram(self.word)) then
       table.insert(result, t[i])
     end
   end

exercises/practice/anagram/.meta/spec_generator.lua

@@ -0,0 +1,42 @@
+local function map(t, f)
+  local mapped = {}
+  for i, v in ipairs(t) do
+    mapped[i] = f(v)
+  end
+  return mapped
+end
+
+local function render_list(list)
+  return '{ ' .. table.concat(map(list, function(v)
+    return "'" .. v .. "'"
+  end), ', ') .. ' }'
+end
+
+return {
+  module_name = 'Anagram',
+
+  test_helpers = [[
+    local function sorted_clone(t)
+      local clone = {}
+      for k, v in pairs(t) do
+        clone[k] = v
+      end
+      table.sort(clone)
+      return clone
+    end
+
+    local function assert_lists_are_same(expected, actual)
+      assert.are.same(sorted_clone(expected), sorted_clone(actual))
+    end
+  ]],
+
+  generate_test = function(case)
+    local template = [[
+      local detector = Anagram:new('%s')
+      local result = detector:match(%s)
+      local expected = %s
+      assert_lists_are_same(expected, result)]]
+
+    return template:format(case.input.subject, render_list(case.input.candidates), render_list(case.expected))
+  end
+}

exercises/practice/anagram/.meta/tests.toml

@@ -1,12 +1,24 @@
-# This is an auto-generated file. Regular comments will be removed when this
-# file is regenerated. Regenerating will not touch any manually added keys,
-# so comments can be added in a "comment" key.
+# This is an auto-generated file.
+#
+# Regenerating this file via `configlet sync` will:
+# - Recreate every `description` key/value pair
+# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications
+# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion)
+# - Preserve any other key/value pair
+#
+# As user-added comments (using the # character) will be removed when this file
+# is regenerated, comments can be added via a `comment` key.
 
 [dd40c4d2-3c8b-44e5-992a-f42b393ec373]
 description = "no matches"
 
 [b3cca662-f50a-489e-ae10-ab8290a09bdc]
 description = "detects two anagrams"
+include = false
+
+[03eb9bbe-8906-4ea0-84fa-ffe711b52c8b]
+description = "detects two anagrams"
+reimplements = "b3cca662-f50a-489e-ae10-ab8290a09bdc"
 
 [a27558ee-9ba0-4552-96b1-ecf665b06556]
 description = "does not detect anagram subsets"
@@ -34,12 +46,43 @@ description = "detects anagrams using case-insensitive possible matches"
 
 [7cc195ad-e3c7-44ee-9fd2-d3c344806a2c]
 description = "does not detect an anagram if the original word is repeated"
+include = false
+
+[630abb71-a94e-4715-8395-179ec1df9f91]
+description = "does not detect an anagram if the original word is repeated"
+reimplements = "7cc195ad-e3c7-44ee-9fd2-d3c344806a2c"
 
 [9878a1c9-d6ea-4235-ae51-3ea2befd6842]
 description = "anagrams must use all letters exactly once"
 
 [85757361-4535-45fd-ac0e-3810d40debc1]
 description = "words are not anagrams of themselves (case-insensitive)"
+include = false
+
+[68934ed0-010b-4ef9-857a-20c9012d1ebf]
+description = "words are not anagrams of themselves"
+reimplements = "85757361-4535-45fd-ac0e-3810d40debc1"
+
+[589384f3-4c8a-4e7d-9edc-51c3e5f0c90e]
+description = "words are not anagrams of themselves even if letter case is partially different"
+reimplements = "85757361-4535-45fd-ac0e-3810d40debc1"
+
+[ba53e423-7e02-41ee-9ae2-71f91e6d18e6]
+description = "words are not anagrams of themselves even if letter case is completely different"
+reimplements = "85757361-4535-45fd-ac0e-3810d40debc1"
 
 [a0705568-628c-4b55-9798-82e4acde51ca]
 description = "words other than themselves can be anagrams"
+include = false
+
+[33d3f67e-fbb9-49d3-a90e-0beb00861da7]
+description = "words other than themselves can be anagrams"
+reimplements = "a0705568-628c-4b55-9798-82e4acde51ca"
+
+[a6854f66-eec1-4afd-a137-62ef2870c051]
+description = "handles case of greek letters"
+include = false
+
+[fd3509e5-e3ba-409d-ac3d-a9ac84d13296]
+description = "different characters may have the same bytes"
+include = false

exercises/practice/anagram/anagram_spec.lua

@@ -14,31 +14,17 @@ describe('anagram', function()
     assert.are.same(sorted_clone(expected), sorted_clone(actual))
   end
 
-  it('no result', function()
+  it('no matches', function()
     local detector = Anagram:new('diaper')
     local result = detector:match({ 'hello', 'world', 'zombies', 'pants' })
     local expected = {}
     assert_lists_are_same(expected, result)
   end)
 
-  it('detects simple anagram', function()
-    local detector = Anagram:new('ant')
-    local result = detector:match({ 'tan', 'stand', 'at' })
-    local expected = { 'tan' }
-    assert_lists_are_same(expected, result)
-  end)
-
-  it('does not detect false positives', function()
-    local detector = Anagram:new('galea')
-    local result = detector:match({ 'eagle' })
-    local expected = {}
-    assert_lists_are_same(expected, result)
-  end)
-
-  it('detects multiple anagrams', function()
-    local detector = Anagram:new('master')
-    local result = detector:match({ 'stream', 'pigeon', 'maters' })
-    local expected = { 'stream', 'maters' }
+  it('detects two anagrams', function()
+    local detector = Anagram:new('solemn')
+    local result = detector:match({ 'lemons', 'cherry', 'melons' })
+    local expected = { 'lemons', 'melons' }
     assert_lists_are_same(expected, result)
   end)
 
@@ -56,17 +42,87 @@ describe('anagram', function()
     assert_lists_are_same(expected, result)
   end)
 
-  it('detects multiple anagrams', function()
+  it('detects three anagrams', function()
     local detector = Anagram:new('allergy')
     local result = detector:match({ 'gallery', 'ballerina', 'regally', 'clergy', 'largely', 'leading' })
     local expected = { 'gallery', 'regally', 'largely' }
     assert_lists_are_same(expected, result)
   end)
 
+  it('detects multiple anagrams with different case', function()
+    local detector = Anagram:new('nose')
+    local result = detector:match({ 'Eons', 'ONES' })
+    local expected = { 'Eons', 'ONES' }
+    assert_lists_are_same(expected, result)
+  end)
+
+  it('does not detect non-anagrams with identical checksum', function()
+    local detector = Anagram:new('mass')
+    local result = detector:match({ 'last' })
+    local expected = {}
+    assert_lists_are_same(expected, result)
+  end)
+
   it('detects anagrams case-insensitively', function()
     local detector = Anagram:new('Orchestra')
     local result = detector:match({ 'cashregister', 'Carthorse', 'radishes' })
     local expected = { 'Carthorse' }
     assert_lists_are_same(expected, result)
   end)
+
+  it('detects anagrams using case-insensitive subject', function()
+    local detector = Anagram:new('Orchestra')
+    local result = detector:match({ 'cashregister', 'carthorse', 'radishes' })
+    local expected = { 'carthorse' }
+    assert_lists_are_same(expected, result)
+  end)
+
+  it('detects anagrams using case-insensitive possible matches', function()
+    local detector = Anagram:new('orchestra')
+    local result = detector:match({ 'cashregister', 'Carthorse', 'radishes' })
+    local expected = { 'Carthorse' }
+    assert_lists_are_same(expected, result)
+  end)
+
+  it('does not detect an anagram if the original word is repeated', function()
+    local detector = Anagram:new('go')
+    local result = detector:match({ 'goGoGO' })
+    local expected = {}
+    assert_lists_are_same(expected, result)
+  end)
+
+  it('anagrams must use all letters exactly once', function()
+    local detector = Anagram:new('tapper')
+    local result = detector:match({ 'patter' })
+    local expected = {}
+    assert_lists_are_same(expected, result)
+  end)
+
+  it('words are not anagrams of themselves', function()
+    local detector = Anagram:new('BANANA')
+    local result = detector:match({ 'BANANA' })
+    local expected = {}
+    assert_lists_are_same(expected, result)
+  end)
+
+  it('words are not anagrams of themselves even if letter case is partially different', function()
+    local detector = Anagram:new('BANANA')
+    local result = detector:match({ 'Banana' })
+    local expected = {}
+    assert_lists_are_same(expected, result)
+  end)
+
+  it('words are not anagrams of themselves even if letter case is completely different', function()
+    local detector = Anagram:new('BANANA')
+    local result = detector:match({ 'banana' })
+    local expected = {}
+    assert_lists_are_same(expected, result)
+  end)
+
+  it('words other than themselves can be anagrams', function()
+    local detector = Anagram:new('LISTEN')
+    local result = detector:match({ 'LISTEN', 'Silent' })
+    local expected = { 'Silent' }
+    assert_lists_are_same(expected, result)
+  end)
 end)