Update phone-number tests (#589)

Author: ryanplusplus

exercises/practice/phone-number/.meta/example.lua

@@ -1,21 +1,18 @@
-local PhoneNumber = {}
+local function clean(s)
+  s = s:gsub('[()-. ]', '')
 
-function PhoneNumber:new(string_or_number)
-  self.__index = self
-  local n = string.gsub(string_or_number, '%D', '')
-  n = n:match '^1?([2-9]%d%d[2-9]%d%d%d%d%d%d)$' or '0000000000'
+  assert(not s:match('%D'))
+  assert(#s == 10 or #s == 11)
+  assert(#s ~= 11 or s:sub(1, 1) == '1')
 
-  return setmetatable({ number = n }, self)
-end
+  s = s:sub(#s - 9)
 
-function PhoneNumber:areaCode()
-  return self.number:sub(1, 3)
-end
+  local area_code, exchange_code, line_number = s:match('(...)(...)(....)')
+
+  assert(not area_code:match('^[01]'))
+  assert(not exchange_code:match('^[01]'))
 
-function PhoneNumber:__tostring()
-  local phone_format = '(%d) %d-%d'
-  local area_code, central_office_code, station_number = self:areaCode(), self.number:sub(4, 6), self.number:sub(7, 10)
-  return phone_format:format(area_code, central_office_code, station_number)
+  return area_code .. exchange_code .. line_number
 end
 
-return PhoneNumber
+return { clean = clean }

exercises/practice/phone-number/.meta/spec_generator.lua

@@ -0,0 +1,19 @@
+return {
+  module_name = 'phone_number',
+
+  generate_test = function(case)
+    if case.expected.error then
+      local template = [[
+        assert.has_error(function()
+          phone_number.clean('%s')
+        end)]]
+
+      return template:format(case.input.phrase)
+    else
+      local template = [[
+        assert.are.equal('%s', phone_number.clean('%s'))]]
+
+      return template:format(case.expected, case.input.phrase)
+    end
+  end
+}

exercises/practice/phone-number/.meta/tests.toml

@@ -1,6 +1,13 @@
-# This is an auto-generated file. Regular comments will be removed when this
-# file is regenerated. Regenerating will not touch any manually added keys,
-# so comments can be added in a "comment" key.
+# This is an auto-generated file.
+#
+# Regenerating this file via `configlet sync` will:
+# - Recreate every `description` key/value pair
+# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications
+# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion)
+# - Preserve any other key/value pair
+#
+# As user-added comments (using the # character) will be removed when this file
+# is regenerated, comments can be added via a `comment` key.
 
 [79666dce-e0f1-46de-95a1-563802913c35]
 description = "cleans the number"
@@ -13,6 +20,11 @@ description = "cleans numbers with multiple spaces"
 
 [598d8432-0659-4019-a78b-1c6a73691d21]
 description = "invalid when 9 digits"
+include = false
+
+[2de74156-f646-42b5-8638-0ef1d8b58bc2]
+description = "invalid when 9 digits"
+reimplements = "598d8432-0659-4019-a78b-1c6a73691d21"
 
 [57061c72-07b5-431f-9766-d97da7c4399d]
 description = "invalid when 11 digits does not start with a 1"
@@ -25,12 +37,27 @@ description = "valid when 11 digits and starting with 1 even with punctuation"
 
 [c6a5f007-895a-4fc5-90bc-a7e70f9b5cad]
 description = "invalid when more than 11 digits"
+include = false
+
+[4a1509b7-8953-4eec-981b-c483358ff531]
+description = "invalid when more than 11 digits"
+reimplements = "c6a5f007-895a-4fc5-90bc-a7e70f9b5cad"
 
 [63f38f37-53f6-4a5f-bd86-e9b404f10a60]
 description = "invalid with letters"
+include = false
+
+[eb8a1fc0-64e5-46d3-b0c6-33184208e28a]
+description = "invalid with letters"
+reimplements = "63f38f37-53f6-4a5f-bd86-e9b404f10a60"
 
 [4bd97d90-52fd-45d3-b0db-06ab95b1244e]
 description = "invalid with punctuations"
+include = false
+
+[065f6363-8394-4759-b080-e6c8c351dd1f]
+description = "invalid with punctuations"
+reimplements = "4bd97d90-52fd-45d3-b0db-06ab95b1244e"
 
 [d77d07f8-873c-4b17-8978-5f66139bf7d7]
 description = "invalid if area code starts with 0"

exercises/practice/phone-number/phone-number.lua

@@ -1,3 +1,5 @@
-local PhoneNumber = {}
+local function clean(s)
 
-return PhoneNumber
+end
+
+return { clean = clean }

exercises/practice/phone-number/phone-number_spec.lua

@@ -1,38 +1,101 @@
-local PhoneNumber = require('phone-number')
+local phone_number = require('phone-number')
 
 describe('phone-number', function()
-  it('cleans the number (223) 456-7890', function()
-    local phone = PhoneNumber:new('(223) 456-7890')
-    assert.are.equals('2234567890', phone.number)
+  it('cleans the number', function()
+    assert.are.equal('2234567890', phone_number.clean('(223) 456-7890'))
   end)
 
   it('cleans numbers with dots', function()
-    local phone = PhoneNumber:new('223.456.7890')
-    assert.are.equals('2234567890', phone.number)
+    assert.are.equal('2234567890', phone_number.clean('223.456.7890'))
   end)
 
-  it('valid when 11 digits and first digit is 1', function()
-    local phone = PhoneNumber:new('12234567890')
-    assert.are.equals('2234567890', phone.number)
+  it('cleans numbers with multiple spaces', function()
+    assert.are.equal('2234567890', phone_number.clean('223 456   7890   '))
   end)
 
-  it('invalid when 11 digits', function()
-    local phone = PhoneNumber:new('22234567890')
-    assert.are.equals('0000000000', phone.number)
+  it('invalid when 9 digits', function()
+    assert.has_error(function()
+      phone_number.clean('123456789')
+    end)
   end)
 
-  it('invalid when 9 digits', function()
-    local phone = PhoneNumber:new('223456789')
-    assert.are.equals('0000000000', phone.number)
+  it('invalid when 11 digits does not start with a 1', function()
+    assert.has_error(function()
+      phone_number.clean('22234567890')
+    end)
+  end)
+
+  it('valid when 11 digits and starting with 1', function()
+    assert.are.equal('2234567890', phone_number.clean('12234567890'))
+  end)
+
+  it('valid when 11 digits and starting with 1 even with punctuation', function()
+    assert.are.equal('2234567890', phone_number.clean('+1 (223) 456-7890'))
+  end)
+
+  it('invalid when more than 11 digits', function()
+    assert.has_error(function()
+      phone_number.clean('321234567890')
+    end)
+  end)
+
+  it('invalid with letters', function()
+    assert.has_error(function()
+      phone_number.clean('523-abc-7890')
+    end)
+  end)
+
+  it('invalid with punctuations', function()
+    assert.has_error(function()
+      phone_number.clean('523-@:!-7890')
+    end)
+  end)
+
+  it('invalid if area code starts with 0', function()
+    assert.has_error(function()
+      phone_number.clean('(023) 456-7890')
+    end)
+  end)
+
+  it('invalid if area code starts with 1', function()
+    assert.has_error(function()
+      phone_number.clean('(123) 456-7890')
+    end)
+  end)
+
+  it('invalid if exchange code starts with 0', function()
+    assert.has_error(function()
+      phone_number.clean('(223) 056-7890')
+    end)
+  end)
+
+  it('invalid if exchange code starts with 1', function()
+    assert.has_error(function()
+      phone_number.clean('(223) 156-7890')
+    end)
+  end)
+
+  it('invalid if area code starts with 0 on valid 11-digit number', function()
+    assert.has_error(function()
+      phone_number.clean('1 (023) 456-7890')
+    end)
+  end)
+
+  it('invalid if area code starts with 1 on valid 11-digit number', function()
+    assert.has_error(function()
+      phone_number.clean('1 (123) 456-7890')
+    end)
   end)
 
-  it('has an area code', function()
-    local phone = PhoneNumber:new('2234567890')
-    assert.are.equals('223', phone:areaCode())
+  it('invalid if exchange code starts with 0 on valid 11-digit number', function()
+    assert.has_error(function()
+      phone_number.clean('1 (223) 056-7890')
+    end)
   end)
 
-  it('formats a number', function()
-    local phone = PhoneNumber:new('2234567890')
-    assert.are.equals('(223) 456-7890', tostring(phone))
+  it('invalid if exchange code starts with 1 on valid 11-digit number', function()
+    assert.has_error(function()
+      phone_number.clean('1 (223) 156-7890')
+    end)
   end)
 end)