Skip to content

Commit a7e6aba

Browse files
Fix phone number test template (#555)
1 parent 19fc0b7 commit a7e6aba

File tree

5 files changed

+10
-551
lines changed

5 files changed

+10
-551
lines changed

exercises/practice/phone-number/.meta/example.ml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@ let number s =
2525
else
2626
let s = String.filter ~f:(Char.is_digit) s in
2727
match String.length s with
28+
| x when x < 10 -> Error "must not be fewer than 10 digits"
2829
| 10 -> check_valid_first_digits s
2930
| 11 when Char.(String.get s 0 = '1') -> check_valid_first_digits (String.drop_prefix s 1)
3031
| 11 -> Error "11 digits must start with 1"
31-
| x when x > 11 -> Error "more than 11 digits"
32+
| x when x > 11 -> Error "must not be greater than 11 digits"
3233
| _ -> Error "incorrect number of digits"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
(lang dune 1.1)
2-
(version 1.7.0)
2+
(version 1.0)

exercises/practice/phone-number/test.ml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
(* phone-number - 1.7.0 *)
1+
(* phone-number - 1.0 *)
22
open Base
33
open OUnit2
44
open Phone_number
@@ -18,19 +18,19 @@ let tests = [
1818
"cleans numbers with multiple spaces" >::
1919
ae (Ok "2234567890") (number "223 456 7890 ");
2020
"invalid when 9 digits" >::
21-
ae (Error "incorrect number of digits") (number "123456789");
21+
ae (Error "must not be fewer than 10 digits") (number "123456789");
2222
"invalid when 11 digits does not start with a 1" >::
2323
ae (Error "11 digits must start with 1") (number "22234567890");
2424
"valid when 11 digits and starting with 1" >::
2525
ae (Ok "2234567890") (number "12234567890");
2626
"valid when 11 digits and starting with 1 even with punctuation" >::
2727
ae (Ok "2234567890") (number "+1 (223) 456-7890");
2828
"invalid when more than 11 digits" >::
29-
ae (Error "more than 11 digits") (number "321234567890");
29+
ae (Error "must not be greater than 11 digits") (number "321234567890");
3030
"invalid with letters" >::
31-
ae (Error "letters not permitted") (number "123-abc-7890");
31+
ae (Error "letters not permitted") (number "523-abc-7890");
3232
"invalid with punctuations" >::
33-
ae (Error "punctuations not permitted") (number "123-@:!-7890");
33+
ae (Error "punctuations not permitted") (number "523-@:!-7890");
3434
"invalid if area code starts with 0" >::
3535
ae (Error "area code cannot start with zero") (number "(023) 456-7890");
3636
"invalid if area code starts with 1" >::

0 commit comments

Comments
 (0)