Skip to content

Commit 5302ef1

Browse files
committed
🚨 Run linter, improve constant naming
1 parent f39b042 commit 5302ef1

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/FilesRepresenter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,15 @@ public function represent(string $code): string
4949
assert($ast !== null, 'Ast should not be null. Check parser\'s `$errorHandler`.');
5050

5151
$this->logger->debug(LazyString::fromCallable(
52-
static fn () => 'AST Before normalization: ' . (new NodeDumper())->dump($ast)
52+
static fn () => 'AST Before normalization: ' . (new NodeDumper())->dump($ast),
5353
));
5454

5555
$visitor = new NormalizeNodeVisitor($this->mapping);
5656
$traverser = new NodeTraverser($visitor);
5757
$ast = $traverser->traverse($ast);
5858

5959
$this->logger->debug(LazyString::fromCallable(
60-
static fn () => 'AST After normalization: ' . (new NodeDumper())->dump($ast)
60+
static fn () => 'AST After normalization: ' . (new NodeDumper())->dump($ast),
6161
));
6262

6363
return $this->prettyPrinter->prettyPrint($ast);

src/Mapping.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818

1919
class Mapping
2020
{
21-
private const FUNCTION_PREFIX = 'fn';
22-
private const VARIABLE_PREFIX = 'v';
23-
private const CLASS_PREFIX = 'C';
24-
private const METHOD_PREFIX = 'm';
21+
private const string PREFIX_FUNCTION = 'fn';
22+
private const string PREFIX_VARIABLE = 'v';
23+
private const string PREFIX_CLASS = 'C';
24+
private const string PREFIX_METHOD = 'm';
2525

2626
/** @var array<string, MappingEntry> */
2727
private array $invertedFunctionMapping = [];
@@ -107,7 +107,7 @@ public function addFunction(string $name): string
107107

108108
$stableName = $unaliasedName;
109109
} else {
110-
$stableName = self::FUNCTION_PREFIX . count($this->invertedFunctionMapping);
110+
$stableName = self::PREFIX_FUNCTION . count($this->invertedFunctionMapping);
111111
}
112112

113113
$this->invertedFunctionMapping[$lcName] = $entry = new MappingEntry($stableName);
@@ -122,7 +122,7 @@ public function addVariable(string $name): string
122122
{
123123
$entry = $this->invertedVariableMapping[$name] ?? null;
124124
if ($entry === null) {
125-
$stableName = self::VARIABLE_PREFIX . count($this->invertedVariableMapping);
125+
$stableName = self::PREFIX_VARIABLE . count($this->invertedVariableMapping);
126126
$this->invertedVariableMapping[$name] = $entry = new MappingEntry($stableName);
127127
$entry->addValue($name);
128128
}
@@ -135,7 +135,7 @@ public function addClass(string $name): string
135135
// TRANSFORM: Class names are case-insensitive in PHP
136136
$lcName = strtolower($name);
137137
$entry = $this->invertedClassMapping[$lcName]
138-
??= new MappingEntry(self::CLASS_PREFIX . count($this->invertedClassMapping));
138+
??= new MappingEntry(self::PREFIX_CLASS . count($this->invertedClassMapping));
139139
$entry->addValue($name);
140140

141141
return $entry->getStableName();
@@ -146,7 +146,7 @@ public function addMethod(string $name): string
146146
// TRANSFORM: Method names are case-insensitive in PHP
147147
$lcName = strtolower($name);
148148
$entry = $this->invertedMethodMapping[$lcName]
149-
??= new MappingEntry(self::METHOD_PREFIX . count($this->invertedMethodMapping));
149+
??= new MappingEntry(self::PREFIX_METHOD . count($this->invertedMethodMapping));
150150
$entry->addValue($name);
151151

152152
return $entry->getStableName();

0 commit comments

Comments
 (0)