Skip to content

Commit 044e6a1

Browse files
dbhjunedevpetertseng
authored
Roman Numerals max out at 3999 (#2094 #2475)
Update exercises/roman-numerals/description.md and tests to support up to 3999. Co-authored-by: June <[email protected]> Co-authored-by: Peter Tseng <[email protected]>
1 parent 26d7c92 commit 044e6a1

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

exercises/roman-numerals/canonical-data.json

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,24 @@
242242
"number": 1666
243243
},
244244
"expected": "MDCLXVI"
245+
},
246+
{
247+
"uuid": "3bc4b41c-c2e6-49d9-9142-420691504336",
248+
"description": "3001 is MMMI",
249+
"property": "roman",
250+
"input": {
251+
"number": 3001
252+
},
253+
"expected": "MMMI"
254+
},
255+
{
256+
"uuid": "4e18e96b-5fbb-43df-a91b-9cb511fe0856",
257+
"description": "3999 is MMMCMXCIX",
258+
"property": "roman",
259+
"input": {
260+
"number": 3999
261+
},
262+
"expected": "MMMCMXCIX"
245263
}
246264
]
247265
}

exercises/roman-numerals/description.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ into stone tablets).
2020
7 => VII
2121
```
2222

23-
There is no need to be able to convert numbers larger than about 3000.
23+
The maximum number supported by this notation is 3,999.
2424
(The Romans themselves didn't tend to go any higher)
2525

2626
Wikipedia says: Modern Roman numerals ... are written by expressing each

0 commit comments

Comments
 (0)