-
-
Notifications
You must be signed in to change notification settings - Fork 557
Add new exercise: line-up #2595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxe-i
reviewed
Oct 4, 2025
IsaacG
reviewed
Oct 4, 2025
ErikSchierboom
approved these changes
Oct 5, 2025
oxe-i
approved these changes
Oct 5, 2025
IsaacG
approved these changes
Oct 5, 2025
BNAndras
approved these changes
Oct 5, 2025
keiravillekode
approved these changes
Oct 6, 2025
Contributor
Author
|
@IsaacG @ErikSchierboom Who can merge this? |
Member
I thought you would be able to merge it once it was approved. I can merge it. |
|
|
||
| - Numbers ending in 1 (except for 11) → `"st"` | ||
| - Numbers ending in 2 (except for 12) → `"nd"` | ||
| - Numbers ending in 3 (except for 13) → `"rd"` |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this should have been (unless ending in 13) to allow for numbers like 913.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed in a forum thread for review
Thanks for comments / corrections of wording and naming. The exercise name might be changed also.
Edit:
f-puzzles.comhave not updated their TLS certificate, that's why the link checker currently fails.