Updated Exercise docs, toml files, test files and example solutions for: (#3329)

* Palindrom Products (toml and tests)
* Roman Numerals (tests)
* Phone Number (toml, tests, and example solution)
* Resistor Color Trio (intro, toml, tests, and example solution)

Author: BethanyG

exercises/practice/palindrome-products/.meta/tests.toml

@@ -1,12 +1,19 @@
-# This is an auto-generated file. Regular comments will be removed when this
-# file is regenerated. Regenerating will not touch any manually added keys,
-# so comments can be added in a "comment" key.
+# This is an auto-generated file.
+#
+# Regenerating this file via `configlet sync` will:
+# - Recreate every `description` key/value pair
+# - Recreate every `reimplements` key/value pair, where they exist in problem-specifications
+# - Remove any `include = true` key/value pair (an omitted `include` key implies inclusion)
+# - Preserve any other key/value pair
+#
+# As user-added comments (using the # character) will be removed when this file
+# is regenerated, comments can be added via a `comment` key.
 
 [5cff78fe-cf02-459d-85c2-ce584679f887]
-description = "finds the smallest palindrome from single digit factors"
+description = "find the smallest palindrome from single digit factors"
 
 [0853f82c-5fc4-44ae-be38-fadb2cced92d]
-description = "finds the largest palindrome from single digit factors"
+description = "find the largest palindrome from single digit factors"
 
 [66c3b496-bdec-4103-9129-3fcb5a9063e1]
 description = "find the smallest palindrome from double digit factors"
@@ -15,13 +22,13 @@ description = "find the smallest palindrome from double digit factors"
 description = "find the largest palindrome from double digit factors"
 
 [cecb5a35-46d1-4666-9719-fa2c3af7499d]
-description = "find smallest palindrome from triple digit factors"
+description = "find the smallest palindrome from triple digit factors"
 
 [edab43e1-c35f-4ea3-8c55-2f31dddd92e5]
 description = "find the largest palindrome from triple digit factors"
 
 [4f802b5a-9d74-4026-a70f-b53ff9234e4e]
-description = "find smallest palindrome from four digit factors"
+description = "find the smallest palindrome from four digit factors"
 
 [787525e0-a5f9-40f3-8cb2-23b52cf5d0be]
 description = "find the largest palindrome from four digit factors"
@@ -37,3 +44,6 @@ description = "error result for smallest if min is more than max"
 
 [eeeb5bff-3f47-4b1e-892f-05829277bd74]
 description = "error result for largest if min is more than max"
+
+[16481711-26c4-42e0-9180-e2e4e8b29c23]
+description = "smallest product does not use the smallest factor"

exercises/practice/palindrome-products/palindrome_products_test.py

@@ -71,5 +71,10 @@ def test_error_result_for_largest_if_min_is_more_than_max(self):
         self.assertEqual(type(err.exception), ValueError)
         self.assertEqual(err.exception.args[0], "min must be <= max")
 
+    def test_smallest_product_does_not_use_the_smallest_factor(self):
+        value, factors = smallest(min_factor=3215, max_factor=4000)
+        self.assertEqual(value, 10988901)
+        self.assertFactorsEqual(factors, [[3297, 3333]])
+
     def assertFactorsEqual(self, actual, expected):
         self.assertEqual(set(map(frozenset, actual)), set(map(frozenset, expected)))

exercises/practice/phone-number/.docs/instructions.append.md

@@ -10,10 +10,10 @@ To raise a `ValueError` with a message, write the message as an argument to the
 
 ```python
 # if a phone number has less than 10 digits.
-raise ValueError("incorrect number of digits")
+raise ValueError("must not be fewer than 10 digits")
 
 # if a phone number has more than 11 digits.
-raise ValueError("more than 11 digits")
+raise ValueError("must not be greater than 11 digits")
 
 # if a phone number has 11 digits, but starts with a number other than 1.
 raise ValueError("11 digits must start with 1")

exercises/practice/phone-number/.meta/example.py

@@ -25,10 +25,10 @@ def _clean(self, number):
 
     def _normalize(self, number):
         if len(number) < 10:
-            raise ValueError('incorrect number of digits')
+            raise ValueError('must not be fewer than 10 digits')
 
         if len(number) > 11:
-            raise ValueError('more than 11 digits')
+            raise ValueError('must not be greater than 11 digits')
 
         if len(number) == 10 or len(number) == 11 and number.startswith('1'):
             if number[-10] == '0':

exercises/practice/phone-number/.meta/tests.toml

@@ -20,6 +20,11 @@ description = "cleans numbers with multiple spaces"
 
 [598d8432-0659-4019-a78b-1c6a73691d21]
 description = "invalid when 9 digits"
+include = false
+
+[2de74156-f646-42b5-8638-0ef1d8b58bc2]
+description = "invalid when 9 digits"
+reimplements = "598d8432-0659-4019-a78b-1c6a73691d21"
 
 [57061c72-07b5-431f-9766-d97da7c4399d]
 description = "invalid when 11 digits does not start with a 1"
@@ -32,6 +37,11 @@ description = "valid when 11 digits and starting with 1 even with punctuation"
 
 [c6a5f007-895a-4fc5-90bc-a7e70f9b5cad]
 description = "invalid when more than 11 digits"
+include = false
+
+[4a1509b7-8953-4eec-981b-c483358ff531]
+description = "invalid when more than 11 digits"
+reimplements = "c6a5f007-895a-4fc5-90bc-a7e70f9b5cad"
 
 [63f38f37-53f6-4a5f-bd86-e9b404f10a60]
 description = "invalid with letters"

exercises/practice/phone-number/phone_number_test.py

@@ -24,7 +24,7 @@ def test_invalid_when_9_digits(self):
         with self.assertRaises(ValueError) as err:
             PhoneNumber("123456789")
         self.assertEqual(type(err.exception), ValueError)
-        self.assertEqual(err.exception.args[0], "incorrect number of digits")
+        self.assertEqual(err.exception.args[0], "must not be fewer than 10 digits")
 
     def test_invalid_when_11_digits_does_not_start_with_a_1(self):
         with self.assertRaises(ValueError) as err:
@@ -44,7 +44,7 @@ def test_invalid_when_more_than_11_digits(self):
         with self.assertRaises(ValueError) as err:
             PhoneNumber("321234567890")
         self.assertEqual(type(err.exception), ValueError)
-        self.assertEqual(err.exception.args[0], "more than 11 digits")
+        self.assertEqual(err.exception.args[0], "must not be greater than 11 digits")
 
     def test_invalid_with_letters(self):
         with self.assertRaises(ValueError) as err:

exercises/practice/resistor-color-trio/.docs/instructions.md

@@ -46,9 +46,11 @@ So an input of `"orange", "orange", "black"` should return:
 
 > "33 ohms"
 
-When we get more than a thousand ohms, we say "kiloohms".
-That's similar to saying "kilometer" for 1000 meters, and "kilograms" for 1000 grams.
+When we get to larger resistors, a [metric prefix][metric-prefix] is used to indicate a larger magnitude of ohms, such as "kiloohms".
+That is similar to saying "2 kilometers" instead of "2000 meters", or "2 kilograms" for "2000 grams".
 
-So an input of `"orange", "orange", "orange"` should return:
+For example, an input of `"orange", "orange", "orange"` should return:
 
 > "33 kiloohms"
+
+[metric-prefix]: https://en.wikipedia.org/wiki/Metric_prefix

exercises/practice/resistor-color-trio/.meta/example.py

@@ -1,18 +1,32 @@
 COLORS = [
-    'black',
-    'brown',
-    'red',
-    'orange',
-    'yellow',
-    'green',
-    'blue',
-    'violet',
-    'grey',
-    'white'
+        'black',
+        'brown',
+        'red',
+        'orange',
+        'yellow',
+        'green',
+        'blue',
+        'violet',
+        'grey',
+        'white'
 ]
 
 
 def label(colors):
     value = 10 * COLORS.index(colors[0]) + COLORS.index(colors[1])
     value *= 10 ** COLORS.index(colors[2])
-    return str(value) + ' ohms' if value < 1000 else str(value // 1000) + ' kiloohms'
+    label = str(value)
+
+    if len(label) < 4 :
+        unit = 'ohms'
+    elif len(label) < 7:
+        label = str(value//1000)
+        unit = 'kiloohms'
+    elif len(label) <= 8 :
+        label = str(value//1000000)
+        unit = 'megaohms'
+    elif len(label) >= 9:
+        label = str(value//1000000000)
+        unit = 'gigaohms'
+
+    return f'{value if value < 1000 else label} {unit}'

exercises/practice/resistor-color-trio/.meta/tests.toml

@@ -23,3 +23,18 @@ description = "Green and brown and orange"
 
 [f5d37ef9-1919-4719-a90d-a33c5a6934c9]
 description = "Yellow and violet and yellow"
+
+[5f6404a7-5bb3-4283-877d-3d39bcc33854]
+description = "Blue and violet and blue"
+
+[7d3a6ab8-e40e-46c3-98b1-91639fff2344]
+description = "Minimum possible value"
+
+[ca0aa0ac-3825-42de-9f07-dac68cc580fd]
+description = "Maximum possible value"
+
+[0061a76c-903a-4714-8ce2-f26ce23b0e09]
+description = "First two colors make an invalid octal number"
+
+[30872c92-f567-4b69-a105-8455611c10c4]
+description = "Ignore extra colors"

exercises/practice/resistor-color-trio/resistor_color_trio_test.py

@@ -22,3 +22,18 @@ def test_green_and_brown_and_orange(self):
 
     def test_yellow_and_violet_and_yellow(self):
         self.assertEqual(label(["yellow", "violet", "yellow"]), "470 kiloohms")
+
+    def test_blue_and_violet_and_blue(self):
+        self.assertEqual(label(["blue", "violet", "blue"]), "67 megaohms")
+
+    def test_minimum_possible_value(self):
+        self.assertEqual(label(["black", "black", "black"]), "0 ohms")
+
+    def test_maximum_possible_value(self):
+        self.assertEqual(label(["white", "white", "white"]), "99 gigaohms")
+
+    def test_first_two_colors_make_an_invalid_octal_number(self):
+        self.assertEqual(label(["black", "grey", "black"]), "8 ohms")
+
+    def test_ignore_extra_colors(self):
+        self.assertEqual(label(["blue", "green", "yellow", "orange"]), "650 kiloohms")