Dnd character add test template (#2136)

* Add test template for dnd character

* Fix import statement

* Write templates for the last 3 tests

* Change assert and remove hardcode test

* Remove hardcoded code

Author: tqa236

exercises/dnd-character/.meta/template.j2

@@ -0,0 +1,41 @@
+{%- import "generator_macros.j2" as macros with context -%}
+{% set class = exercise | camel_case -%}
+{{ macros.header(["Character", "modifier"]) }}
+
+class {{ exercise | camel_case }}Test(unittest.TestCase):
+    {% for supercase in cases -%}
+    {% set property = supercase["property"] -%}
+    {% set description = supercase["description"] | to_snake -%}
+    {% if "cases" in supercase -%}
+    {% for case in supercase["cases"] -%}
+    def test_{{ case["description"] | replace("-","n") | to_snake }}(self):
+        {% set value = case["input"]["score"] -%}
+        {% set expected = case["expected"] -%}
+        self.assertEqual({{ case["property"] }}({{ value }}), {{ expected }})
+    {% endfor %}
+
+    {% elif property == "ability" -%}
+    def test_{{ description }}(self):
+        score = Character().{{ property }}()
+        self.assertIs({{ supercase["expected"] | replace("&&","and") }}, True)
+
+    {% elif property == "character" -%}
+    def test_{{ description}}(self):
+        Char = Character()
+        {% for ability in supercase["expected"] -%}
+        {% set statement = supercase["expected"][ability] | replace("&&","and") | replace(ability, ["Char.", ability ]|join("")) -%}
+        {% if ability == "hitpoints" -%}
+        {% set statement = statement | replace("constitution","Char.constitution") -%}
+        {%- endif -%}
+        self.assertIs({{ statement }}, True)
+        {% endfor %}
+
+    {% elif property == "strength" -%}
+    def test_{{ description }}(self):
+        Char = Character()
+        self.assertIs({{ supercase["expected"] | replace(property , ["Char.", property]|join(""))}}, True)
+
+    {%- endif -%}
+    {% endfor %}
+
+{{ macros.footer() }}

exercises/dnd-character/dnd_character_test.py

@@ -2,77 +2,76 @@
 
 from dnd_character import Character, modifier
 
-
 # Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0
 
-class DnDCharacterTest(unittest.TestCase):
-    def test_modifier_for_score_3_is_n4(self):
+
+class DndCharacterTest(unittest.TestCase):
+    def test_ability_modifier_for_score_3_is_n4(self):
         self.assertEqual(modifier(3), -4)
 
-    def test_modifier_for_score_4_is_n3(self):
+    def test_ability_modifier_for_score_4_is_n3(self):
         self.assertEqual(modifier(4), -3)
 
-    def test_modifier_for_score_5_is_n3(self):
+    def test_ability_modifier_for_score_5_is_n3(self):
         self.assertEqual(modifier(5), -3)
 
-    def test_modifier_for_score_6_is_n2(self):
+    def test_ability_modifier_for_score_6_is_n2(self):
         self.assertEqual(modifier(6), -2)
 
-    def test_modifier_for_score_7_is_n2(self):
+    def test_ability_modifier_for_score_7_is_n2(self):
         self.assertEqual(modifier(7), -2)
 
-    def test_modifier_for_score_8_is_n1(self):
+    def test_ability_modifier_for_score_8_is_n1(self):
         self.assertEqual(modifier(8), -1)
 
-    def test_modifier_for_score_9_is_n1(self):
+    def test_ability_modifier_for_score_9_is_n1(self):
         self.assertEqual(modifier(9), -1)
 
-    def test_modifier_for_score_10_is_0(self):
+    def test_ability_modifier_for_score_10_is_0(self):
         self.assertEqual(modifier(10), 0)
 
-    def test_modifier_for_score_11_is_0(self):
+    def test_ability_modifier_for_score_11_is_0(self):
         self.assertEqual(modifier(11), 0)
 
-    def test_modifier_for_score_12_is_1(self):
+    def test_ability_modifier_for_score_12_is_1(self):
         self.assertEqual(modifier(12), 1)
 
-    def test_modifier_for_score_13_is_1(self):
+    def test_ability_modifier_for_score_13_is_1(self):
         self.assertEqual(modifier(13), 1)
 
-    def test_modifier_for_score_14_is_2(self):
+    def test_ability_modifier_for_score_14_is_2(self):
         self.assertEqual(modifier(14), 2)
 
-    def test_modifier_for_score_15_is_2(self):
+    def test_ability_modifier_for_score_15_is_2(self):
         self.assertEqual(modifier(15), 2)
 
-    def test_modifier_for_score_16_is_3(self):
+    def test_ability_modifier_for_score_16_is_3(self):
         self.assertEqual(modifier(16), 3)
 
-    def test_modifier_for_score_17_is_3(self):
+    def test_ability_modifier_for_score_17_is_3(self):
         self.assertEqual(modifier(17), 3)
 
-    def test_modifier_for_score_18_is_4(self):
+    def test_ability_modifier_for_score_18_is_4(self):
         self.assertEqual(modifier(18), 4)
 
     def test_random_ability_is_within_range(self):
-        self.assertIn(Character().ability(), range(3, 19))
+        score = Character().ability()
+        self.assertIs(score >= 3 and score <= 18, True)
 
     def test_random_character_is_valid(self):
         Char = Character()
-        self.assertIn(Char.strength, range(3, 19))
-        self.assertIn(Char.dexterity, range(3, 19))
-        self.assertIn(Char.constitution, range(3, 19))
-        self.assertIn(Char.intelligence, range(3, 19))
-        self.assertIn(Char.wisdom, range(3, 19))
-        self.assertIn(Char.charisma, range(3, 19))
-        self.assertEqual(
-            Char.hitpoints,
-            10 + modifier(Char.constitution))
+        self.assertIs(Char.strength >= 3 and Char.strength <= 18, True)
+        self.assertIs(Char.dexterity >= 3 and Char.dexterity <= 18, True)
+        self.assertIs(Char.constitution >= 3 and Char.constitution <= 18, True)
+        self.assertIs(Char.intelligence >= 3 and Char.intelligence <= 18, True)
+        self.assertIs(Char.wisdom >= 3 and Char.wisdom <= 18, True)
+        self.assertIs(Char.charisma >= 3 and Char.charisma <= 18, True)
+        self.assertIs(Char.hitpoints == 10 + modifier(Char.constitution), True)
 
     def test_each_ability_is_only_calculated_once(self):
         Char = Character()
-        self.assertEqual(Char.strength, Char.strength)
+        self.assertIs(Char.strength == Char.strength, True)
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     unittest.main()