Sync bob tests (#422)

Author: BNAndras

exercises/practice/bob/.meta/example.rkt

@@ -20,6 +20,6 @@
        (ormap (lambda (x) (char-alphabetic? x)) (string->list phrase))))
 
 (define (question? phrase)
-  (char=? #\?
-          (string-ref phrase
-                      (- (string-length phrase) 1))))
+  (let ([trimmed (string-trim phrase)])
+    (and (not (string=? trimmed ""))
+         (char=? #\? (string-ref trimmed (sub1 (string-length trimmed)))))))

exercises/practice/bob/.meta/tests.toml

@@ -71,6 +71,7 @@ description = "alternate silence"
 
 [66953780-165b-4e7e-8ce3-4bcb80b6385a]
 description = "multiple line question"
+include = false
 
 [5371ef75-d9ea-4103-bcfa-2da973ddec1b]
 description = "starting with whitespace"
@@ -83,3 +84,7 @@ description = "other whitespace"
 
 [12983553-8601-46a8-92fa-fcaa3bc4a2a0]
 description = "non-question ending with whitespace"
+
+[2c7278ac-f955-4eb4-bf8f-e33eb4116a15]
+description = "multiple line question"
+reimplements = "66953780-165b-4e7e-8ce3-4bcb80b6385a"

exercises/practice/bob/bob-test.rkt

@@ -9,60 +9,104 @@
     (test-suite
      "bob tests"
 
-     (test-equal? "responds to something"
+     (test-equal? "stating something"
                   (response-for "To-may-to, tom-aaaah-to.")
                   "Whatever.")
 
-     (test-equal? "responds to shouts"
+     (test-equal? "shouting"
                   (response-for "WATCH OUT!")
                   "Whoa, chill out!")
 
-     (test-equal? "responds to questions"
+     (test-equal? "shouting gibberish"
+                  (response-for "FCECDFCAAB")
+                  "Whoa, chill out!")
+
+     (test-equal? "asking a question"
                   (response-for "Does this cryogenic chamber make me look fat?")
                   "Sure.")
 
-     (test-equal? "responds to forceful talking"
-                  (response-for "Let's go make out behind the gym!")
+     (test-equal? "asking a numeric question"
+                  (response-for "You are, what, like 15?")
+                  "Sure.")
+
+     (test-equal? "asking gibberish"
+                  (response-for "fffbbcbeab?")
+                  "Sure.")
+
+     (test-equal? "talking forcefully"
+                  (response-for "Hi there!")
                   "Whatever.")
 
-     (test-equal? "responds to acronyms"
-                  (response-for "It's OK if you don't want to go to the DMV.")
+     (test-equal? "using acronyms in regular speech"
+                  (response-for "It's OK if you don't want to go work for NASA.")
                   "Whatever.")
 
-     (test-equal? "responds to forceful questions"
-                  (response-for "WHAT THE HELL WERE YOU THINKING?")
+     (test-equal? "forceful question"
+                  (response-for "WHAT'S GOING ON?")
                   "Calm down, I know what I'm doing!")
 
-     (test-equal? "responds to shouting with special characters"
-                  (response-for "ZOMG THE %^*@#$(*^ ZOMBIES ARE COMING!!11!!1!")
+     (test-equal? "shouting numbers"
+                  (response-for "1, 2, 3 GO!")
                   "Whoa, chill out!")
 
-     (test-equal? "responds to shouting numbers"
-                  (response-for "1, 2 ,3, GO!")
+     (test-equal? "no letters"
+                  (response-for "1, 2, 3")
+                  "Whatever.")
+
+     (test-equal? "question with no letters"
+                  (response-for "4?")
+                  "Sure.")
+
+     (test-equal? "shouting with special characters"
+                  (response-for "ZOMG THE %^*@#$(*^ ZOMBIES ARE COMING!!11!!1!")
                   "Whoa, chill out!")
 
-     (test-equal? "responds to shouting with no exclamation mark"
-                  (response-for "I HATE YOU")
+     (test-equal? "shouting with no exclamation mark"
+                  (response-for "I HATE THE DENTIST")
                   "Whoa, chill out!")
 
-     (test-equal? "responds to statement containing question mark"
+     (test-equal? "statement containing question mark"
                   (response-for "Ending with ? means a question.")
                   "Whatever.")
 
-     (test-equal? "responds to silence"
+     (test-equal? "non-letters with question"
+                  (response-for ":) ?")
+                  "Sure.")
+
+     (test-equal? "prattling on"
+                  (response-for "Wait! Hang on. Are you going to be OK?")
+                  "Sure.")
+
+     (test-equal? "silence"
                   (response-for "")
                   "Fine. Be that way!")
 
-     (test-equal? "responds to prolonged-silence"
-                  (response-for "     ")
+     (test-equal? "prolonged silence"
+                  (response-for "          ")
                   "Fine. Be that way!")
 
-     (test-equal? "responds to only-numbers"
-                  (response-for "1, 2, 3")
+     (test-equal? "alternate silence"
+                  (response-for "\t\t\t\t\t\t\t\t\t\t")
+                  "Fine. Be that way!")
+
+     (test-equal? "multiple line question"
+                  (response-for "\nDoes this cryogenic chamber make\n me look fat?")
+                  "Sure.")
+
+     (test-equal? "starting with whitespace"
+                  (response-for "         hmmmmmmm...")
                   "Whatever.")
 
-     (test-equal? "responds to number-question"
-                  (response-for "4?")
-                  "Sure.")))
+     (test-equal? "ending with whitespace"
+                  (response-for "Okay if like my  spacebar  quite a bit?   ")
+                  "Sure.")
+    
+     (test-equal? "other whitespace"
+                  (response-for "\n\r \t")
+                  "Fine. Be that way!")
+
+     (test-equal? "non-question ending with whitespace"
+                  (response-for "This is a statement ending with whitespace      ")
+                  "Whatever.")))
 
   (run-tests suite))