Approve acronym when using scan method

Author: kntsoriano

lib/analyzers/acronym/analyze.rb

@@ -3,7 +3,7 @@ class Analyze < ExerciseAnalyzer
     include Mandate
 
     def analyze!
-      if solution.uses_method_chain? || solution.uses_scan?
+      if solution.uses_method_chain? || solution.uses_scan? || solution.uses_split?
         self.status = :approve
 
         raise FinishedFlowControlException

lib/analyzers/acronym/representation.rb

@@ -39,6 +39,34 @@ def uses_scan?
         all? { |node, i| node_matches?(node, matchers[i]) }
     end
 
+    def uses_split?
+      matchers = [
+        {
+          method_name: :upcase,
+        },
+        {
+          method_name: :join,
+          chained?: true
+        },
+        {
+          method_name: :map,
+          chained?: true,
+          arguments: [{ to_ast: s(:block_pass, s(:sym, :chr)) }]
+        },
+        {
+          method_name: :split,
+          receiver: s(:lvar, :words),
+          arguments: [{ type: :regexp }]
+        }
+      ]
+
+      target_method.
+        body.
+        each_node(:send).
+        with_index.
+        all? { |node, i| node_matches?(node, matchers[i]) }
+    end
+
     private
     memoize
     def target_method

test/exercises/acronym_test.rb

@@ -27,4 +27,17 @@ def self.abbreviate(words)
     assert_equal :approve, results[:status]
     assert_equal [], results[:comments]
   end
+
+  def test_split_with_any_regex_passes
+    source = %q{
+      class Acronym
+        def self.abbreviate(words)
+          words.split(/[ -]/).map(&:chr).join.upcase
+        end
+      end
+    }
+    results = Acronym::Analyze.(source)
+    assert_equal :approve, results[:status]
+    assert_equal [], results[:comments]
+  end
 end