Sync queen-attack with problem-specifications

The sync brought in changes to the documentation, new titles for
all the tests, and a new test.

The regenerated test suite didn't require any changes to the
sample solution.

Author: kytrinyx

exercises/practice/queen-attack/.docs/instructions.md

@@ -1,27 +1,25 @@
 # Instructions
 
-Given the position of two queens on a chess board, indicate whether or not they
-are positioned so that they can attack each other.
+Given the position of two queens on a chess board, indicate whether or not they are positioned so that they can attack each other.
 
-In the game of chess, a queen can attack pieces which are on the same
-row, column, or diagonal.
+In the game of chess, a queen can attack pieces which are on the same row, column, or diagonal.
 
 A chessboard can be represented by an 8 by 8 array.
 
-So if you're told the white queen is at (2, 3) and the black queen at
-(5, 6), then you'd know you've got a set-up like so:
+So if you are told the white queen is at `c5` (zero-indexed at column 2, row 3) and the black queen at `f2` (zero-indexed at column 5, row 6), then you know that the set-up is like so:
 
 ```text
-_ _ _ _ _ _ _ _
-_ _ _ _ _ _ _ _
-_ _ _ W _ _ _ _
-_ _ _ _ _ _ _ _
-_ _ _ _ _ _ _ _
-_ _ _ _ _ _ B _
-_ _ _ _ _ _ _ _
-_ _ _ _ _ _ _ _
+  a b c d e f g h
+8 _ _ _ _ _ _ _ _ 8
+7 _ _ _ _ _ _ _ _ 7
+6 _ _ _ _ _ _ _ _ 6
+5 _ _ W _ _ _ _ _ 5
+4 _ _ _ _ _ _ _ _ 4
+3 _ _ _ _ _ _ _ _ 3
+2 _ _ _ _ _ B _ _ 2
+1 _ _ _ _ _ _ _ _ 1
+  a b c d e f g h
 ```
 
-You'd also be able to answer whether the queens can attack each other.
-In this case, that answer would be yes, they can, because both pieces
-share a diagonal.
+You are also be able to answer whether the queens can attack each other.
+In this case, that answer would be yes, they can, because both pieces share a diagonal.

exercises/practice/queen-attack/.meta/tests.toml

@@ -10,37 +10,40 @@
 # is regenerated, comments can be added via a `comment` key.
 
 [3ac4f735-d36c-44c4-a3e2-316f79704203]
-description = "queen with a valid position"
+description = "Test creation of Queens with valid and invalid positions -> queen with a valid position"
 
 [4e812d5d-b974-4e38-9a6b-8e0492bfa7be]
-description = "queen must have positive row"
+description = "Test creation of Queens with valid and invalid positions -> queen must have positive row"
 
 [f07b7536-b66b-4f08-beb9-4d70d891d5c8]
-description = "queen must have row on board"
+description = "Test creation of Queens with valid and invalid positions -> queen must have row on board"
 
 [15a10794-36d9-4907-ae6b-e5a0d4c54ebe]
-description = "queen must have positive column"
+description = "Test creation of Queens with valid and invalid positions -> queen must have positive column"
 
 [6907762d-0e8a-4c38-87fb-12f2f65f0ce4]
-description = "queen must have column on board"
+description = "Test creation of Queens with valid and invalid positions -> queen must have column on board"
 
 [33ae4113-d237-42ee-bac1-e1e699c0c007]
-description = "can not attack"
+description = "Test the ability of one queen to attack another -> cannot attack"
 
 [eaa65540-ea7c-4152-8c21-003c7a68c914]
-description = "can attack on same row"
+description = "Test the ability of one queen to attack another -> can attack on same row"
 
 [bae6f609-2c0e-4154-af71-af82b7c31cea]
-description = "can attack on same column"
+description = "Test the ability of one queen to attack another -> can attack on same column"
 
 [0e1b4139-b90d-4562-bd58-dfa04f1746c7]
-description = "can attack on first diagonal"
+description = "Test the ability of one queen to attack another -> can attack on first diagonal"
 
 [ff9b7ed4-e4b6-401b-8d16-bc894d6d3dcd]
-description = "can attack on second diagonal"
+description = "Test the ability of one queen to attack another -> can attack on second diagonal"
 
 [0a71e605-6e28-4cc2-aa47-d20a2e71037a]
-description = "can attack on third diagonal"
+description = "Test the ability of one queen to attack another -> can attack on third diagonal"
 
 [0790b588-ae73-4f1f-a968-dd0b34f45f86]
-description = "can attack on fourth diagonal"
+description = "Test the ability of one queen to attack another -> can attack on fourth diagonal"
+
+[543f8fd4-2597-4aad-8d77-cbdab63619f8]
+description = "Test the ability of one queen to attack another -> cannot attack if falling diagonals are only the same when reflected across the longest falling diagonal"

exercises/practice/queen-attack/queen_attack_test.rb

@@ -2,78 +2,76 @@
 require_relative 'queen_attack'
 
 class QueenAttackTest < Minitest::Test
-  def test_queen_with_a_valid_position
+  def test_new_queen_with_a_valid_position
     # skip
     assert Queens.new(white: [2, 2])
   end
 
-  def test_queen_must_have_positive_row
+  def test_new_queen_must_have_positive_row
     skip
     assert_raises(ArgumentError) do
       Queens.new(white: [-2, 2])
     end
   end
 
-  def test_queen_must_have_row_on_board
+  def test_new_queen_must_have_row_on_board
     skip
     assert_raises(ArgumentError) do
       Queens.new(white: [8, 4])
     end
   end
 
-  def test_queen_must_have_positive_column
+  def test_new_queen_must_have_positive_column
     skip
     assert_raises(ArgumentError) do
       Queens.new(white: [2, -2])
     end
   end
 
-  def test_queen_must_have_column_on_board
+  def test_new_queen_must_have_column_on_board
     skip
     assert_raises(ArgumentError) do
       Queens.new(white: [4, 8])
     end
   end
 
-  def test_can_not_attack
+  def test_queens_cannot_attack
     skip
-    queens = Queens.new(white: [2, 4], black: [6, 6])
-    refute queens.attack?
+    refute Queens.new(white: [2, 4], black: [6, 6]).attack?
   end
 
-  def test_can_attack_on_same_row
+  def test_queens_can_attack_on_same_row
     skip
-    queens = Queens.new(white: [2, 4], black: [2, 6])
-    assert queens.attack?
+    assert Queens.new(white: [2, 4], black: [2, 6]).attack?
   end
 
-  def test_can_attack_on_same_column
+  def test_queens_can_attack_on_same_column
     skip
-    queens = Queens.new(white: [4, 5], black: [2, 5])
-    assert queens.attack?
+    assert Queens.new(white: [4, 5], black: [2, 5]).attack?
   end
 
-  def test_can_attack_on_first_diagonal
+  def test_queens_can_attack_on_first_diagonal
     skip
-    queens = Queens.new(white: [2, 2], black: [0, 4])
-    assert queens.attack?
+    assert Queens.new(white: [2, 2], black: [0, 4]).attack?
   end
 
-  def test_can_attack_on_second_diagonal
+  def test_queens_can_attack_on_second_diagonal
     skip
-    queens = Queens.new(white: [2, 2], black: [3, 1])
-    assert queens.attack?
+    assert Queens.new(white: [2, 2], black: [3, 1]).attack?
   end
 
-  def test_can_attack_on_third_diagonal
+  def test_queens_can_attack_on_third_diagonal
     skip
-    queens = Queens.new(white: [2, 2], black: [1, 1])
-    assert queens.attack?
+    assert Queens.new(white: [2, 2], black: [1, 1]).attack?
   end
 
-  def test_can_attack_on_fourth_diagonal
+  def test_queens_can_attack_on_fourth_diagonal
     skip
-    queens = Queens.new(white: [2, 2], black: [5, 5])
-    assert queens.attack?
+    assert Queens.new(white: [1, 7], black: [0, 6]).attack?
+  end
+
+  def test_queens_cannot_attack_if_falling_diagonals_are_only_the_same_when_reflected_across_the_longest_falling_diagonal
+    skip
+    refute Queens.new(white: [4, 1], black: [2, 5]).attack?
   end
 end