Skip to content

Commit 400f30a

Browse files
authored
Fix implicit clone warning in satellite example (#278)
Fixes the following type of warning: Notice: temp/satellite.v:54:21: notice: an implicit clone of the slice was done here 52 | 53 | value := preorder[0] 54 | preorder = preorder[1..(preorder.len)] | ~~~~~~~~~~~~~~~~~~~ 55 | 56 | left := traverse(value, mut preorder, mut inorder)! Details: temp/satellite.v:54:21: details: To silence this notice, use either an explicit `a[..].clone()`, or use an explicit `unsafe{ a[..] }`, if you do not want a copy of the slice. 52 | 53 | value := preorder[0] 54 | preorder = preorder[1..(preorder.len)] | ~~~~~~~~~~~~~~~~~~~ 55 | 56 | left := traverse(value, mut preorder, mut inorder)
1 parent ef1931e commit 400f30a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

exercises/practice/satellite/.meta/example.v

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,15 @@ fn traverse(successor ?rune, mut preorder []rune, mut inorder []rune) !Tree {
5151
}
5252

5353
value := preorder[0]
54-
preorder = preorder[1..(preorder.len)]
54+
preorder = preorder[1..(preorder.len)].clone()
5555

5656
left := traverse(value, mut preorder, mut inorder)!
5757

5858
if inorder.len == 0 || inorder[0] != value {
5959
return error('traversals must have the same elements')
6060
}
6161

62-
inorder = inorder[1..(inorder.len)]
62+
inorder = inorder[1..(inorder.len)].clone()
6363

6464
right := traverse(successor, mut preorder, mut inorder)!
6565

0 commit comments

Comments
 (0)