Fix time parsing in gigasecond tests #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
Member
Author
|
Btw, the break in the Gigasecond test seems to have been caused by this commit in Vlang: vlang/v@c55a75f |
kahgoh
force-pushed
the
fix/gigasecond
branch
3 times, most recently
from
ae5676d to
3b112ec
Compare
This fixes the parsing of the date strings in the tests. According to the docs the, a couple of the dates are in ISO 8601 format rather than RFC 3339. RFC 3339 requires the time zone to be specified when the String contains a time. ISO 8601 doesn't have this requirment. See: - https://modules.vlang.io/time.html#parse_rfc3339 - https://ijmacd.github.io/rfc3339-iso8601/
keiravillekode
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #232, this is to fix the Gigasecond tests (failed in test run https://github.com/exercism/vlang/actions/runs/11506925109).
This fixes the parsing of the date strings in the tests. According to the docs the, a couple of the dates are in ISO 8601 format rather than RFC 3339. RFC 3339 requires the time zone to be specified when the String contains a time. ISO 8601 doesn't have this requirment.
See:
When merging, I think it should be marked
[no important files changed]as this commit shouldn't change any past test results.