Skip to content

Commit 30ca2a1

Browse files
committed
multiprocessing.Queue has no task_done()
See https://docs.python.org/2/library/multiprocessing.html#pipes-and-queues Specifically: "The Queue, multiprocessing.queues.SimpleQueue and JoinableQueue types are multi-producer, multi-consumer FIFO queues modelled on the Queue.Queue class in the standard library. They differ in that Queue lacks the task_done() and join() methods introduced into Python 2.5’s Queue.Queue class."
1 parent 6ca13f3 commit 30ca2a1

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

cluster/matrix.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,8 @@ def worker(self):
5858
for task in iter(self.task_queue.get, 'STOP'):
5959
col_index, item, item2 = task
6060
result = (col_index, self.combinfunc(item, item2))
61-
self.task_queue.task_done()
6261
self.done_queue.put(result)
6362
tasks_completed += 1
64-
self.task_queue.task_done()
6563
logger.info("Worker %s performed %s tasks",
6664
current_process().name,
6765
tasks_completed)
@@ -117,7 +115,6 @@ def genmatrix(self, num_processes=1):
117115
# blocking operation)
118116
if num_tasks_queued > num_processes:
119117
col_index, result = self.done_queue.get()
120-
self.done_queue.task_done()
121118
row[col_index] = result
122119
num_tasks_completed += 1
123120
else:
@@ -136,7 +133,6 @@ def genmatrix(self, num_processes=1):
136133
# Grab the remaining worker task results
137134
while num_tasks_completed < num_tasks_queued:
138135
col_index, result = self.done_queue.get()
139-
self.done_queue.task_done()
140136
row[col_index] = result
141137
num_tasks_completed += 1
142138

0 commit comments

Comments
 (0)