chore: clippy fixes

Signed-off-by: Henry Gressmann <[email protected]>

Author: explodingcamera

Cargo.lock

@@ -6,6 +6,10 @@ rust-version="1.80"
 repository="https://github.com/explodingcamera/liwan"
 
 [dependencies]
+tokio={version="1.38", default-features=false, features=["rt-multi-thread"]}
+tokio-util={version="0.7", features=["io"]}
+futures-util="0.3"
+
 # encoding
 hex={version="0.4"}
 bs58="0.5.1"
@@ -28,19 +32,17 @@ crossbeam="0.8"
 cached="0.53"
 tracing="0.1"
 tracing-subscriber={version="0.3", features=["env-filter"]}
+async-compression="0.4.12"
+tokio-tar={package="krata-tokio-tar", version="0.4.0"}
 
 # web
-tokio={version="1.38", default-features=false, features=["rt-multi-thread"]}
-tokio-util={version="0.7", features=["io"]}
 poem={version="3.0", features=["embed", "session", "cookie", "compression", "tower-compat"]}
 poem-openapi={version="5.0", features=["chrono"]}
 tower={version="0.4.8", default-features=false, features=["limit"]}
 uaparser="0.6"
 mime_guess={version="2.0"}
 rust-embed="8.4"
 reqwest={version="0.12", features=["json", "stream"]}
-tokio-tar={package="krata-tokio-tar", version="0.4.0"}
-async-compression="0.4.12"
 
 # database
 duckdb={version="1.0", features=["bundled", "chrono", "r2d2"]}
@@ -50,7 +52,6 @@ r2d2_sqlite="0.25.0"
 refinery={version="0.8"}
 refinery-core="0.8"
 maxminddb={version="0.24", optional=true}
-futures="0.3.30"
 
 [features]
 default=["geoip"]

Cargo.toml

@@ -1,3 +1,5 @@
+#![allow(dead_code)]
+
 use std::{
     collections::HashMap,
     path::{Path, PathBuf},
@@ -10,7 +12,7 @@ use std::{
 use crate::app::SqlitePool;
 use crossbeam::sync::ShardedLock;
 use eyre::{OptionExt, Result};
-use futures::{StreamExt, TryStreamExt};
+use futures_util::{StreamExt, TryStreamExt};
 use md5::{Digest, Md5};
 use tokio_tar::Archive;
 use tokio_util::io::StreamReader;
@@ -134,7 +136,7 @@ async fn get_latest_md5(edition: &str, account_id: &str, license_key: &str) -> R
     Ok(response
         .get("databases")
         .ok_or_eyre("No databases found")?
-        .get(0)
+        .first()
         .ok_or_eyre("MD5 hash not found")?
         .get("md5")
         .ok_or_eyre("MD5 hash not found")?
@@ -161,8 +163,8 @@ async fn download_maxmind_db(edition: &str, account_id: &str, license_key: &str)
     let mut archive = Archive::new(stream);
     let mut entries = archive.entries()?;
 
-    let folder = PathBuf::from(std::env::temp_dir()).join("liwan-geoip");
-    let mut file = PathBuf::new();
+    let folder = std::env::temp_dir().join("liwan-geoip");
+    let file;
     loop {
         let mut entry = entries
             .next()
@@ -171,7 +173,6 @@ async fn download_maxmind_db(edition: &str, account_id: &str, license_key: &str)
             .map_err(|e| eyre::eyre!("Failed to read entry: {}", e))?;
 
         let entry_path = entry.path()?;
-
         if entry_path.extension().map_or(false, |ext| ext == "mmdb") {
             file = entry
                 .unpack_in(folder)

src/app/core/geoip.rs

@@ -38,12 +38,12 @@ pub(super) fn init_sqlite(
 
     {
         let conn = pool.get()?;
-        conn.pragma_update(None, "foreign_keys", &"ON")?;
-        conn.pragma_update(None, "journal_mode", &"WAL")?;
-        conn.pragma_update(None, "synchronous", &"NORMAL")?;
-        conn.pragma_update(None, "mmap_size", &"268435456")?;
-        conn.pragma_update(None, "journal_size_limit", &"268435456")?;
-        conn.pragma_update(None, "cache_size", &"2000")?;
+        conn.pragma_update(None, "foreign_keys", "ON")?;
+        conn.pragma_update(None, "journal_mode", "WAL")?;
+        conn.pragma_update(None, "synchronous", "NORMAL")?;
+        conn.pragma_update(None, "mmap_size", "268435456")?;
+        conn.pragma_update(None, "journal_size_limit", "268435456")?;
+        conn.pragma_update(None, "cache_size", "2000")?;
     }
 
     Ok(pool)

src/app/db.rs

@@ -84,8 +84,8 @@ impl Liwan {
             ("entity-2", "Entity 2", "test.example.com", vec!["private-project".to_string()]),
             ("entity-3", "Entity 3", "example.org", vec!["public-project".to_string()]),
         ];
-        let projects = vec![("public-project", "Public Project", true), ("private-project", "Private Project", false)];
-        let users = vec![("admin", "admin", UserRole::Admin), ("user", "user", UserRole::User)];
+        let projects = [("public-project", "Public Project", true), ("private-project", "Private Project", false)];
+        let users = [("admin", "admin", UserRole::Admin), ("user", "user", UserRole::User)];
 
         for (username, password, role) in users.iter() {
             self.users.create(username, password, *role, &[])?;

src/app/mod.rs

@@ -74,7 +74,7 @@ fn random_date(min: DateTime<Utc>, max: DateTime<Utc>, scale: f64) -> DateTime<U
     min + weighted_duration
 }
 
-fn random_el<'a, T>(slice: &'a [T], scale: f64) -> &'a T {
+fn random_el<T>(slice: &[T], scale: f64) -> &T {
     let mut rng = rand::thread_rng();
     let len = slice.len();