feat: full multi-memory support

Signed-off-by: Henry Gressmann <[email protected]>

Author: explodingcamera

CHANGELOG.md

@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Full support for Multi-Memory proposal
+- Extern tables now correctly update their type after growing
 - Increased MSRV to 1.80.0
 - Improved support for WebAssembly 2.0 features
 - Simplify and optimize the interpreter loop

README.md

@@ -14,41 +14,35 @@
 
 - **Tiny**: TinyWasm is designed to be as small as possible without significantly compromising performance or functionality (< 4000 LLOC).
 - **Portable**: TinyWasm runs on any platform that Rust can target, including `no_std`, with minimal external dependencies.
-- **Safe**: No unsafe code is used in the runtime (`rkyv` which uses unsafe code can be used for serialization, but it is optional).
+- **Safe**: No unsafe code is used in the runtime (`rkyv` which uses unsafe code can be used for serialization, but is optional).
 
 ## Status
 
-As of version `0.3.0`, TinyWasm successfully passes all the WebAssembly 1.0 tests in the [WebAssembly Test Suite](https://github.com/WebAssembly/testsuite). Work on the 2.0 tests is ongoing. This enables TinyWasm to run most WebAssembly programs, including executing TinyWasm itself compiled to WebAssembly (see [examples/wasm-rust.rs](./examples/wasm-rust.rs)). The results of the testsuites are available [here](https://github.com/explodingcamera/tinywasm/tree/main/crates/tinywasm/tests/generated).
-
-The API is still unstable and may change at any time, so you probably don't want to use it in production _yet_. TinyWasm isn't primarily designed for high performance; it focuses more on simplicity, size, and portability. Benchmarks are currently being reworked and will be available again soon.
-
-**Future Development**: The first major version will focus on improving the API and adding support for [WASI](https://wasi.dev/). While doing so, I also want to further simplify and reduce the codebase's size and improve the parser's performance.
+TinyWasm passes all WebAssembly MVP tests from the [WebAssembly core testsuite](https://github.com/WebAssembly/testsuite) and is able to run most WebAssembly programs. Additionally, the current 2.0 Draft is mostly supported, with the exception of Fixed-Width SIMD and Memory64/Multiple Memories. See the [Supported Proposals](#supported-proposals) section for more information.
 
 ## Supported Proposals
 
-| Proposal                                                                                                                   | Implementation Status | Version |
-| -------------------------------------------------------------------------------------------------------------------------- | --------------------- | ------- |
-| [**Mutable Globals**](https://github.com/WebAssembly/mutable-global/blob/master/proposals/mutable-global/Overview.md)      | Fully implemented     | 0.2.0   |
-| [**Multi-value**](https://github.com/WebAssembly/spec/blob/master/proposals/multi-value/Overview.md)                       | Fully implemented     | 0.2.0   |
-| [**Sign-extension operators**](https://github.com/WebAssembly/spec/blob/master/proposals/sign-extension-ops/Overview.md)   | Fully implemented     | 0.2.0   |
-| [**Bulk Memory Operations**](https://github.com/WebAssembly/spec/blob/master/proposals/bulk-memory-operations/Overview.md) | Fully implemented     | 0.4.0   |
-| [**Reference Types**](https://github.com/WebAssembly/reference-types/blob/master/proposals/reference-types/Overview.md)    | Partially implemented | N/A     |
-| [**Multiple Memories**](https://github.com/WebAssembly/multi-memory/blob/master/proposals/multi-memory/Overview.md)        | Partially implemented | N/A     |
-| [**Memory64**](https://github.com/WebAssembly/memory64/blob/master/proposals/memory64/Overview.md)                         | Partially implemented | N/A     |
+**Legend**\
+🌑 -- not available\
+🚧 -- in development / partialy supported\
+🟢 -- fully supported
+
+| Proposal                                                                                                                   | Status | TinyWasm Version |
+| -------------------------------------------------------------------------------------------------------------------------- | ------ | ---------------- |
+| [**Mutable Globals**](https://github.com/WebAssembly/mutable-global/blob/master/proposals/mutable-global/Overview.md)      | 🟢     | 0.2.0            |
+| [**Non-trapping float-to-int Conversion**](https://github.com/WebAssembly/nontrapping-float-to-int-conversions)            | 🟢     | 0.2.0            |
+| [**Sign-extension operators**](https://github.com/WebAssembly/sign-extension-ops)                                          | 🟢     | 0.2.0            |
+| [**Multi-value**](https://github.com/WebAssembly/spec/blob/master/proposals/multi-value/Overview.md)                       | 🟢     | 0.2.0            |
+| [**Bulk Memory Operations**](https://github.com/WebAssembly/spec/blob/master/proposals/bulk-memory-operations/Overview.md) | 🟢     | 0.4.0            |
+| [**Reference Types**](https://github.com/WebAssembly/reference-types/blob/master/proposals/reference-types/Overview.md)    | 🟢     | 0.7.0            |
+| [**Multiple Memories**](https://github.com/WebAssembly/multi-memory/blob/master/proposals/multi-memory/Overview.md)        | 🟢     | 0.8.0            |
+| [**Memory64**](https://github.com/WebAssembly/memory64/blob/master/proposals/memory64/Overview.md)                         | 🚧     | N/A              |
+| [**Fixed-Width SIMD**](https://github.com/webassembly/simd)                                                                | 🌑     | N/A              |
 
 ## Usage
 
-TinyWasm can be used through the `tinywasm-cli` CLI tool or as a library in your Rust project. Documentation can be found [here](https://docs.rs/tinywasm).
-
-### Library
-
-```sh
-$ cargo add tinywasm
-```
-
-### CLI
-
-The CLI is mainly available for testing purposes, but can also be used to run WebAssembly programs.
+See the [examples](./examples) directory and [documentation](https://docs.rs/tinywasm) for more information on how to use TinyWasm.
+For testing purposes, you can also use the `tinywasm-cli` tool:
 
 ```sh
 $ cargo install tinywasm-cli
@@ -78,7 +72,7 @@ Big thanks to the authors of the following projects, which have inspired and inf
 - [wazero](https://wazero.io/) - a zero-dependency WebAssembly interpreter written in go
 - [wain](https://github.com/rhysd/wain) - a zero-dependency WebAssembly interpreter written in Rust
 
-I encourage you to check these projects out if you're looking for a more mature and feature-complete WebAssembly interpreter.
+I encourage you to check these projects out if you're looking for more mature and feature-complete WebAssembly Runtimes.
 
 ## License
 

crates/parser/src/lib.rs

@@ -60,6 +60,7 @@ impl Parser {
             saturating_float_to_int: true,
             function_references: true,
             tail_call: true,
+            multi_memory: true,
 
             gc_types: true,
             component_model: false,
@@ -74,7 +75,6 @@ impl Parser {
             relaxed_simd: false,
             simd: false,
             threads: false,
-            multi_memory: false, // should be working mostly
             custom_page_sizes: false,
             shared_everything_threads: false,
             component_model_multiple_returns: false,

crates/tinywasm/src/imports.rs

@@ -392,7 +392,9 @@ impl Imports {
                         }
                         (ExternVal::Table(table_addr), ImportKind::Table(ty)) => {
                             let table = store.get_table(table_addr);
-                            Self::compare_table_types(import, &table.kind, ty)?;
+                            let mut kind = table.kind.clone();
+                            kind.size_initial = table.size() as u32;
+                            Self::compare_table_types(import, &kind, ty)?;
                             imports.tables.push(table_addr);
                         }
                         (ExternVal::Memory(memory_addr), ImportKind::Memory(ty)) => {

crates/tinywasm/src/interpreter/executor.rs

@@ -540,7 +540,7 @@ impl<'store, 'stack> Executor<'store, 'stack> {
             let (mem_from, mem_to) =
                 self.store.get_mems_mut(self.module.resolve_mem_addr(from), self.module.resolve_mem_addr(to))?;
 
-            mem_to.copy_from_slice(dst as usize, mem_from.load(src as usize, size as usize)?)?;
+            mem_from.copy_from_slice(dst as usize, mem_to.load(src as usize, size as usize)?)?;
         }
         Ok(())
     }

crates/tinywasm/src/store/mod.rs

@@ -368,11 +368,6 @@ impl Store {
         for (i, data) in datas.into_iter().enumerate() {
             let data_val = match data.kind {
                 tinywasm_types::DataKind::Active { mem: mem_addr, offset } => {
-                    // a. Assert: memidx == 0
-                    if mem_addr != 0 {
-                        return Err(Error::UnsupportedFeature("data segments for non-zero memories".to_string()));
-                    }
-
                     let Some(mem_addr) = mem_addrs.get(mem_addr as usize) else {
                         return Err(Error::Other(format!("memory {mem_addr} not found for data segment {i}")));
                     };