Skip to content

Commit 90db3ba

Browse files
authored
fix: validation was incorrect (#75)
1 parent 2b9734d commit 90db3ba

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/ragas/validation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def validate_evaluation_modes(ds: Dataset, metrics: list[Metric]):
4747
for m in metrics:
4848
required_columns = set(EVALMODE_TO_COLUMNS[m.evaluation_mode])
4949
available_columns = set(ds.features.keys())
50-
if required_columns.symmetric_difference(available_columns):
50+
if not required_columns.issubset(available_columns):
5151
raise ValueError(
5252
f"The metric [{m.name}] that that is used requires the following "
5353
f"additional columns {list(required_columns - available_columns)} "

tests/unit/test_validation.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@
1212

1313
TEST_CASES = [
1414
CaseToTest("a", "b", ["c"], None, True, [faithfulness], True),
15-
CaseToTest("a", "b", ["c"], ["g"], True, [faithfulness], False),
15+
CaseToTest("a", "b", ["c"], ["g"], True, [faithfulness], True),
1616
CaseToTest("a", None, ["c"], None, True, [context_relevancy], True),
1717
CaseToTest("a", None, "c", None, False, [context_relevancy], True),
1818
CaseToTest(
1919
"a", None, [["c"]], None, False, [context_relevancy, answer_relevancy], False
2020
),
21-
CaseToTest("a", None, ["c"], "g", False, [context_relevancy], False),
22-
CaseToTest("a", None, ["c"], [["g"]], False, [context_relevancy], False),
23-
CaseToTest(1, None, ["c"], ["g"], False, [context_relevancy], False),
21+
CaseToTest("a", None, ["c"], "g", False, [context_relevancy], True),
22+
CaseToTest("a", None, ["c"], [["g"]], False, [context_relevancy], True),
23+
CaseToTest(1, None, ["c"], ["g"], False, [context_relevancy], True),
2424
CaseToTest(1, None, None, None, False, [context_relevancy], False),
2525
]
2626

0 commit comments

Comments
 (0)