Skip to content

Commit 99d9425

Browse files
authored
fix: add missing query qualifier (#1733)
fixes: #1718
1 parent 1ac4eac commit 99d9425

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

src/ragas/testset/synthesizers/multi_hop/abstract.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ async def _generate_scenarios(
116116
nodes,
117117
concept_combination.combinations,
118118
personas=persona_list,
119-
persona_item_mapping=persona_concepts.mappping,
119+
persona_item_mapping=persona_concepts.mapping,
120120
property_name="themes",
121121
)
122122
base_scenarios = self.sample_diverse_combinations(

src/ragas/testset/synthesizers/multi_hop/specific.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,16 @@ class MultiHopSpecificQuerySynthesizer(MultiHopQuerySynthesizer):
4343
theme_persona_matching_prompt: PydanticPrompt = ThemesPersonasMatchingPrompt()
4444
generate_query_reference_prompt: PydanticPrompt = QueryAnswerGenerationPrompt()
4545

46+
def get_node_clusters(self, knowledge_graph: KnowledgeGraph) -> t.List[t.Tuple]:
47+
48+
node_clusters = knowledge_graph.find_two_nodes_single_rel(
49+
relationship_condition=lambda rel: (
50+
True if rel.type == self.relation_type else False
51+
)
52+
)
53+
logger.info("found %d clusters", len(node_clusters))
54+
return node_clusters
55+
4656
async def _generate_scenarios(
4757
self,
4858
n: int,
@@ -63,11 +73,7 @@ async def _generate_scenarios(
6373
4. Return the list of scenarios of length n
6474
"""
6575

66-
triplets = knowledge_graph.find_two_nodes_single_rel(
67-
relationship_condition=lambda rel: (
68-
True if rel.type == self.relation_type else False
69-
)
70-
)
76+
triplets = self.get_node_clusters(knowledge_graph)
7177

7278
if len(triplets) == 0:
7379
raise ValueError(
@@ -97,7 +103,7 @@ async def _generate_scenarios(
97103
[node_a, node_b],
98104
overlapped_items,
99105
personas=persona_list,
100-
persona_item_mapping=persona_concepts.mappping,
106+
persona_item_mapping=persona_concepts.mapping,
101107
property_name=self.property_name,
102108
)
103109
base_scenarios = self.sample_diverse_combinations(

0 commit comments

Comments
 (0)