Skip to content

Commit 40f9bea

Browse files
committed
fix: consistencies NFT class
Signed-off-by: exploreriii <[email protected]>
1 parent c494f0f commit 40f9bea

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

src/hiero_sdk_python/tokens/nft_id.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,34 +4,36 @@
44
from hiero_sdk_python.hapi.services import basic_types_pb2
55
from hiero_sdk_python.tokens.token_id import TokenId
66

7-
@dataclass(frozen=True, init=True, repr=True, eq=True)
7+
@dataclass(frozen=True)
88
class NftId:
99
"""
10-
A unique identifiers for Non-Fungible Tokens (NFTs).
10+
A unique identifier for Non-Fungible Tokens (NFTs).
1111
The NftId has a TokenId, and a serial number.
1212
"""
1313

1414
tokenId: TokenId
1515
serialNumber: int
1616

17-
def __post_init__(self) -> bool:
17+
def __post_init__(self) -> None:
1818
"""Validate the NftId after initialization."""
1919
if self.tokenId is None:
20-
raise TypeError("token_id is required")
20+
raise TypeError("TokenId is required")
2121
if not isinstance(self.tokenId, TokenId):
22-
raise TypeError(f"token_id must be of type TokenId, got {type(self.tokenId)}")
22+
raise TypeError(f"TokenId must be of type TokenId, got {type(self.tokenId)}")
2323
if not isinstance(self.serialNumber, int):
24-
raise TypeError(f"Expected an integer for serial_number, got {type(self.serialNumber)}")
24+
raise TypeError(f"Expected an integer for serialNumber, got {type(self.serialNumber)}")
2525
if self.serialNumber < 0:
26-
raise ValueError("serial_number must be positive")
27-
return True
26+
raise ValueError("serial_number must be non-negative")
27+
return None
2828

2929
@classmethod
3030
def _from_proto(cls, nft_id_proto: Optional[basic_types_pb2.NftID] = None) -> "NftId":
3131
"""
3232
:param nft_id_proto: the proto NftID object
3333
:return: a NftId object
3434
"""
35+
if nft_id_proto is None:
36+
raise ValueError("NftID protobuf message is required")
3537
return cls(
3638
tokenId=TokenId._from_proto(nft_id_proto.token_ID),
3739
serialNumber=nft_id_proto.serial_number

0 commit comments

Comments
 (0)