Skip to content

Commit 72eaca2

Browse files
committed
feat: backward compatability warning and logger order
Signed-off-by: exploreriii <[email protected]>
1 parent 5f28a6a commit 72eaca2

File tree

2 files changed

+28
-4
lines changed

2 files changed

+28
-4
lines changed

src/hiero_sdk_python/logger/log_level.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@ class LogLevel(IntEnum):
1818
ERROR = 40
1919
CRITICAL = 50
2020
DISABLED = 60
21-
21+
22+
#Old warn method will be depreciated
23+
WARN = WARNING
24+
2225
def to_python_level(self) -> int:
2326
"""Convert to Python's logging level
2427

src/hiero_sdk_python/logger/logger.py

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import logging
66
import sys
77
from typing import Optional, Union, Sequence
8+
import warnings
89

910
from hiero_sdk_python.logger.log_level import LogLevel
1011

@@ -105,12 +106,32 @@ def warning(self, message: str, *args: object) -> None:
105106
if self.internal_logger.isEnabledFor(LogLevel.WARNING.value):
106107
self.internal_logger.warning(self._format_args(message, args))
107108

109+
def warn(self, message: str, *args) -> None:
110+
"""Legacy warn method replaced by warning"""
111+
warnings.warn(
112+
"Logger.warn() is deprecated; use Logger.warning()",
113+
category=DeprecationWarning,
114+
stacklevel=2,
115+
)
116+
# Redirects to activate the new method
117+
self.warning(message, *args)
118+
108119
def error(self, message: str, *args: object) -> None:
109120
"""Log at ERROR level"""
110121
if self.internal_logger.isEnabledFor(LogLevel.ERROR.value):
111122
self.internal_logger.error(self._format_args(message, args))
112123

113-
def get_logger(level: Optional[LogLevel] = None,
114-
name: Optional[str] = None) -> Logger:
115-
"""Get a logger instance."""
124+
def get_logger(
125+
level: Optional[LogLevel] = None,
126+
name: Optional[str] = None,
127+
) -> Logger:
128+
# Legacy method: pass in name, level
129+
if isinstance(level, str) and isinstance(name, LogLevel):
130+
warnings.warn(
131+
"get_logger(name, level) will be deprecated; use get_logger(level, name)",
132+
DeprecationWarning, stacklevel=2
133+
)
134+
# Swaps them to correct sequence to follow init
135+
level, name = name, level
136+
116137
return Logger(level, name)

0 commit comments

Comments
 (0)