Merge pull request #95 from exploreriii/shared-libraries-guards

feat: enforce intermediate and advanced

Author: exploreriii

.github/scripts/bots/assign-03-intermediate-check.js

@@ -0,0 +1,62 @@
+const { hasIntermediateEligibility } = require('../lib/eligibility/has-eligibility-03-intermediate');
+const { rejectionRouter } = require('../lib/comments/rejection-router');
+
+const INTERMEDIATE_LABEL = 'Intermediate';
+
+function isIntermediate(issue) {
+    return (issue.labels ?? []).some(l => l.name === INTERMEDIATE_LABEL);
+}
+
+module.exports = async ({ github, context }) => {
+    const { issue, assignee } = context.payload;
+    const { owner, repo } = context.repo;
+
+    if (!issue || !assignee) return;
+    if (!isIntermediate(issue)) return;
+
+    const username = assignee.login;
+
+    const result = await hasIntermediateEligibility({
+        github,
+        owner,
+        repo,
+        username,
+    });
+
+    if (result.eligible) {
+        console.log('[intermediate-enforce] Assignment allowed', {
+            issue: issue.number,
+            username,
+        });
+        return;
+    }
+
+    // ❌ Not eligible → unassign
+    await github.rest.issues.removeAssignees({
+        owner,
+        repo,
+        issue_number: issue.number,
+        assignees: [username],
+    });
+
+    const body = rejectionRouter({
+        reason: result.reason,
+        context: result.context,
+        username,
+    });
+
+    if (body) {
+        await github.rest.issues.createComment({
+            owner,
+            repo,
+            issue_number: issue.number,
+            body,
+        });
+    }
+
+    console.log('[intermediate-enforce] Assignment reverted', {
+        issue: issue.number,
+        username,
+        reason: result.reason,
+    });
+};

.github/scripts/bots/assign-04-advanced-check.js

@@ -0,0 +1,69 @@
+const { hasAdvancedEligibility } =
+    require('../lib/eligibility/has-advanced-eligibility');
+const { rejectionRouter } =
+    require('../lib/comments/rejection-router');
+
+const ADVANCED_LABEL = 'Advanced';
+
+function isAdvanced(issue) {
+    return (issue.labels ?? []).some(l => l.name === ADVANCED_LABEL);
+}
+
+module.exports = async ({ github, context }) => {
+    const { issue, assignee } = context.payload;
+    const { owner, repo } = context.repo;
+
+    if (!issue || !assignee) return;
+    if (!isAdvanced(issue)) return;
+
+    const username = assignee.login;
+
+    console.log('[advanced-enforce] Checking eligibility', {
+        issue: issue.number,
+        username,
+    });
+
+    const result = await hasAdvancedEligibility({
+        github,
+        owner,
+        repo,
+        username,
+    });
+
+    if (result.eligible) {
+        console.log('[advanced-enforce] Assignment allowed', {
+            issue: issue.number,
+            username,
+        });
+        return;
+    }
+
+    // ❌ Not eligible → revert assignment
+    await github.rest.issues.removeAssignees({
+        owner,
+        repo,
+        issue_number: issue.number,
+        assignees: [username],
+    });
+
+    const body = rejectionRouter({
+        reason: result.reason,
+        context: result.context,
+        username,
+    });
+
+    if (body) {
+        await github.rest.issues.createComment({
+            owner,
+            repo,
+            issue_number: issue.number,
+            body,
+        });
+    }
+
+    console.log('[advanced-enforce] Assignment reverted', {
+        issue: issue.number,
+        username,
+        reason: result.reason,
+    });
+};

.github/scripts/lib/comments/rejection-router.js

@@ -1,19 +1,34 @@
 const { beginnerRejection } = require('./difficulty-02-beginner');
+const { intermediateRejection } = require('./difficulty-03-intermediate');
+const { advancedRejection } = require('./difficulty-04-advanced');
 const { capacityLimitReached } = require('./max-assignments-reached');
 const { spamNonGfiAssignment } = require('./spam-restrictions');
 
 const REJECTION_REASONS =
     require('../eligibility/rejection-reasons');
 
-const rejectionRouter = ({ reason, context, username, urls }) => {
+const rejectionRouter = ({ reason, context = {}, username, urls = {} }) => {
     switch (reason) {
+        // ───── Beginner → Intermediate ladder
         case REJECTION_REASONS.MISSING_GFI:
-            return beginnerRejection({
+        case REJECTION_REASONS.MISSING_BEGINNER:
+            return intermediateRejection({
                 username,
-                completedGfiCount: context.completedGfiCount,
+                requiredGfiCount: context.requiredGfiCount ?? 1,
+                requiredBeginnerCount: context.requiredBeginnerCount ?? 1,
                 browseGfiUrl: urls.gfi,
+                browseBeginnerUrl: urls.beginner,
             });
 
+        // ───── Intermediate → Advanced ladder
+        case REJECTION_REASONS.MISSING_INTERMEDIATE:
+            return advancedRejection({
+                username,
+                requiredIntermediateCount: context.requiredCount ?? 1,
+                browseIntermediateUrl: urls.intermediate,
+            });
+
+        // ───── Shared rules
         case REJECTION_REASONS.CAPACITY:
             return capacityLimitReached({
                 username,

.github/workflows/bot-advanced-assign-checker.yml

@@ -0,0 +1,29 @@
+name: Enforce Advanced Assignment Eligibility
+
+on:
+    issues:
+        types:
+            - assigned
+
+permissions:
+    issues: write
+    contents: read
+
+jobs:
+    enforce-advanced:
+        runs-on: ubuntu-latest
+
+        concurrency:
+            group: advanced-assign-${{ github.event.issue.number }}
+            cancel-in-progress: false
+
+        steps:
+            - name: Checkout repository
+              uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+
+            - name: Enforce Advanced eligibility
+              uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd #v8.0.0
+              with:
+                  script: |
+                      const script = require('./.github/scripts/bots/assign-04-advanced-check.js');
+                      await script({ github, context });

.github/workflows/bot-beginner-assign-on-comment.yml

@@ -10,15 +10,15 @@ permissions:
     contents: read
 
 jobs:
-    gfi-assign:
+    beginner-assign:
         # Only run on issue comments (not PR comments)
         if: github.event.issue.pull_request == null
 
         runs-on: ubuntu-latest
 
         # Prevent race conditions: always wait for the first assignment request to finish processing
         concurrency:
-            group: gfi-assign-${{ github.event.issue.number }}
+            group: beginner-assign-${{ github.event.issue.number }}
             cancel-in-progress: false
 
         steps:

.github/workflows/bot-intermediate-assign-checker.yml

@@ -0,0 +1,29 @@
+name: Enforce Intermediate Assignment Eligibility
+
+on:
+    issues:
+        types:
+            - assigned
+
+permissions:
+    issues: write
+    contents: read
+
+jobs:
+    enforce-intermediate:
+        runs-on: ubuntu-latest
+
+        concurrency:
+            group: intermediate-assign-${{ github.event.issue.number }}
+            cancel-in-progress: false
+
+        steps:
+            - name: Checkout repository
+              uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+
+            - name: Enforce Advanced eligibility
+              uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd #v8.0.0
+              with:
+                  script: |
+                      const script = require('./.github/scripts/bots/assign-03-intermediate-check.js');
+                      await script({ github, context });