Skip to content

Commit d2d996f

Browse files
committed
chore: code rabbit fixes
Signed-off-by: exploreriii <[email protected]>
1 parent f4f532c commit d2d996f

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

.github/ISSUE_TEMPLATE/01_good_first_issue_candidate.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ body:
244244
value: |
245245
To be able to merge a pull request for this issue, we need:
246246
247-
- [ ] **Assignment:** get assigned by commenting `/assign`[see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/04_assigning_issues.md)
247+
- [ ] **Assignment:** get assigned by commenting `/assign` [see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/04_assigning_issues.md)
248248
- [ ] **Changelog Entry:** Correct changelog entry [see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/changelog_entry.md)
249249
- [ ] **Signed commits:** commits must be DCO and GPG key signed [see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/signing.md)
250250
- [ ] **All Tests Pass:** our workflow checks like unit and integration tests must pass
@@ -261,7 +261,7 @@ body:
261261
value: |
262262
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow.
263263
264-
- [ ] **Assignment:** get assigned by commenting `/assign`[see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/04_assigning_issues.md)
264+
- [ ] **Assignment:** get assigned by commenting `/assign` [see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/04_assigning_issues.md)
265265
- [ ] **Fork, Branch and Work on the issue:** Create a copy of the repository, create a branch for the issue and solve the problem. For instructions, please read our [Contributing guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/CONTRIBUTING.md) file. Further help can be found at [Set-up Training](https://github.com/hiero-ledger/hiero-sdk-python/tree/main/docs/sdk_developers/training/setup) and [Workflow Training](https://github.com/hiero-ledger/hiero-sdk-python/tree/main/docs/sdk_developers/training/workflow).
266266
- [ ] **DCO and GPG key sign each commit :** each commit must be -s and -S signed. An explanation on how to do this is at [Signing Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/signing.md)
267267
- [ ] **Add a Changelog Entry :** your pull request will require a changelog. Read [Changelog Entry Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/changelog_entry.md) to learn how.

.github/ISSUE_TEMPLATE/04_good_first_issue.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ body:
236236
value: |
237237
To be able to merge a pull request for this issue, we need:
238238
239-
- [ ] **Assignment:** get assigned by commenting `/assign`[see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/04_assigning_issues.md)
239+
- [ ] **Assignment:** get assigned by commenting `/assign` [see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/04_assigning_issues.md)
240240
- [ ] **Changelog Entry:** Correct changelog entry [see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/changelog_entry.md)
241241
- [ ] **Signed commits:** commits must be DCO and GPG key signed [see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/signing.md)
242242
- [ ] **All Tests Pass:** our workflow checks like unit and integration tests must pass
@@ -253,7 +253,7 @@ body:
253253
value: |
254254
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow.
255255
256-
- [ ] **Assignment:** get assigned by commenting `/assign`[see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/04_assigning_issues.md)
256+
- [ ] **Assignment:** get assigned by commenting `/assign` [see guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/04_assigning_issues.md)
257257
- [ ] **Fork, Branch and Work on the issue:** Create a copy of the repository, create a branch for the issue and solve the problem. For instructions, please read our [Contributing guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/CONTRIBUTING.md) file. Further help can be found at [Set-up Training](https://github.com/hiero-ledger/hiero-sdk-python/tree/main/docs/sdk_developers/training/setup) and [Workflow Training](https://github.com/hiero-ledger/hiero-sdk-python/tree/main/docs/sdk_developers/training/workflow).
258258
- [ ] **DCO and GPG key sign each commit :** each commit must be -s and -S signed. An explanation on how to do this is at [Signing Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/signing.md)
259259
- [ ] **Add a Changelog Entry :** your pull request will require a changelog. Read [Changelog Entry Guide](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/changelog_entry.md) to learn how.

docs/maintainers/good_first_issue_candidate_guidelines.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Apply the **candidate** label when you believe the issue is a good first issue,
5555
- The issue fits within the **allowed GFI categories** (docs, examples, typing, small mechanical edits)
5656
- The issue is *not* exploratory and does *not* require design decisions
5757

58-
Suitability can be assessed [here](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/maintainers/good_first_issues_guidelines.md)
58+
Suitability can be assessed [GFIC Guidelines](https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/maintainers/good_first_issues_guidelines.md)
5959

6060
### ✅ Requires Some Refinement
6161

docs/maintainers/good_first_issues_guidelines.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ Documentation tasks must be **explicitly scoped** and **instruction-driven**.
8383

8484
#### Allowed
8585

86-
- Remaing variable names when new names are provided
86+
- Renaming variable names when new names are provided
8787
- Fixing identified typos or grammar issues
8888
- Making explicitly provided changes to docstrings, comments or print statements
8989
- Splitting a large example into smaller functions

0 commit comments

Comments
 (0)