Fix regression in Python 3.10 (#68)

crusaderky · web-flow · commit dde24f763e66 · 2025-11-27T16:35:49.000Z
diff --git a/confection/_registry.py b/confection/_registry.py
@@ -268,7 +268,11 @@ def _make_unresolved_schema(
                 )
             elif field.annotation is None:
                 fields[name] = (Any, Field(field.default))
-            elif issubclass(field.annotation, BaseModel):
+            elif (
+                # On Python 3.10, typing.* objects were not classes
+                isinstance(field.annotation, type)
+                and issubclass(field.annotation, BaseModel)
+            ):
                 fields[name] = cls._make_unresolved_schema(
                     field.annotation, config[name]
                 )

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,11 @@ def _make_unresolved_schema(`
`268`	`268`	`)`
`269`	`269`	`elif field.annotation is None:`
`270`	`270`	`fields[name] = (Any, Field(field.default))`
`271`		`- elif issubclass(field.annotation, BaseModel):`
	`271`	`+ elif (`
	`272`	`+ # On Python 3.10, typing.* objects were not classes`
	`273`	`+ isinstance(field.annotation, type)`
	`274`	`+ and issubclass(field.annotation, BaseModel)`
	`275`	`+ ):`
`272`	`276`	`fields[name] = cls._make_unresolved_schema(`
`273`	`277`	`field.annotation, config[name]`
`274`	`278`	`)`