How to use nlp.after_creation or nlp.after_pipeline_creation configs?

[kinghuang]

I'm trying to set overwrite=False on a sourced entity_linker component at runtime, since it's not possible to do this in a config file (see #9640). I've created a callback function like so.

@registry.callbacks("entity_linker_overwrite_false")
def make_entity_linker_overwrite_false():
    def entity_linker_overwrite_false(nlp):
        if nlp.has_pipe("entity_linker"):
            nlp.get_pipe("entity_linker").cfg["overwrite"] = False

And, in my config file, set it for after_pipeline_creation.

[nlp]
lang = "en"
pipeline = ["...","entity_linker","..."]
before_creation = null
after_creation = null
after_pipeline_creation = {"@callbacks": "entity_linker_overwrite_false"}

The callback doesn't seem to work, though. It's never called, and the entity_linker component remains at overwrite=True.

I've also tried putting the callback on after_creation instead, but still no luck. What am I missing?

[adrianeboyd]

I think you might have forgotten to return the callback in the definition?

@registry.callbacks("entity_linker_overwrite_false")
def make_entity_linker_overwrite_false():
    def entity_linker_overwrite_false(nlp):
        if nlp.has_pipe("entity_linker"):
            nlp.get_pipe("entity_linker").cfg["overwrite"] = False

    return entity_linker_overwrite_false

[kinghuang]

🤦 You're totally right. I also forgot to return the nlp object. Thanks!

@registry.callbacks("entity_linker_overwrite_false")
def make_entity_linker_overwrite_false():
    def entity_linker_overwrite_false(nlp):
        if nlp.has_pipe("entity_linker"):
            nlp.get_pipe("entity_linker").cfg["overwrite"] = False

        return nlp

    return entity_linker_overwrite_false