fix: yarn build

Before this commit, and since ab8bc71, this command would fail:
```
error TS6059: File '<>/expo-server-sdk-node/eslint.config.ts' is not under 'rootDir' '<>/expo-server-sdk-node/src'. 'rootDir' is expected to contain all source files.
  The file is in the program because:
    Matched by default include pattern '**/*'
```

We want `tsconfig.json` to include `eslint.config.ts`, so that we detect type
errors in it.  However, we don't want `tsconfig.build.json` to include
it, so that `tsc` doesn't produce build output for it.

To detect this problem in the future, I added a check in the github
tests workflow.

Author: nicknovitski

.github/workflows/tests.yml

@@ -1,27 +1,46 @@
 name: Tests
-on: 
+on:
   push:
-  pull_request:
 jobs:
-  build:
+  typecheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+      - run: corepack enable
+      - uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4
+        with:
+          cache: yarn
+      - run: yarn
+      - run: yarn tsc
+      # This command builds, and then prints files which would be included in the published package
+      - run: yarn pack --dry-run
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+      - run: corepack enable
+      - uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4
+        with:
+          node-version-file: package.json
+          cache: yarn
+      - run: yarn
+      - run: yarn lint --max-warnings=0
+  test:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         node-version: [18, 20, 22]
     steps:
-    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
-    - run: corepack enable
-    - uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4
-      with:
-        node-version: ${{ matrix.node-version }}
-        cache: yarn
-    - run: yarn --immutable
-    - run: yarn add -D @types/node@${{ matrix.node-version }}
-    - run: yarn tsc
-    - run: yarn lint --max-warnings=0
-    - run: yarn test --coverage
-    - uses: codecov/codecov-action@0565863a31f2c772f9f0395002a31e3f06189574 # v5
-      with:
-        flags: "node_${{ matrix.node-version }}"
-      env:
-        CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+      - run: corepack enable
+      - uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: yarn
+      - run: yarn
+      - run: yarn test --coverage
+      - uses: codecov/codecov-action@0565863a31f2c772f9f0395002a31e3f06189574 # v5
+        with:
+          flags: 'node_${{ matrix.node-version }}'
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

package.json

@@ -7,10 +7,13 @@
   "files": [
     "build"
   ],
+  "engines": {
+    "node": ">=18"
+  },
   "scripts": {
-    "build": "tsc --project tsconfig.build.json",
+    "build": "yarn prepack",
     "lint": "eslint",
-    "prepare": "yarn build",
+    "prepack": "tsc --project tsconfig.build.json",
     "test": "jest",
     "tsc": "tsc",
     "watch": "tsc --watch"
@@ -49,8 +52,9 @@
     "promise-retry": "^2.0.1"
   },
   "devDependencies": {
-    "@tsconfig/node-lts": "22.0.1",
+    "@tsconfig/node18": "^18.2.4",
     "@tsconfig/strictest": "2.0.5",
+    "@types/node": "18",
     "@types/node-fetch": "2.6.12",
     "@types/promise-retry": "1.1.6",
     "eslint": "9.26.0",

tsconfig.build.json

@@ -5,5 +5,6 @@
     "outDir": "./build",
     "rootDir": "./src"
   },
-  "exclude": ["node_modules", "**/__mocks__", "**/__tests__", "build", "coverage"]
+  "include": ["src"],
+  "exclude": ["src/__tests__"]
 }

tsconfig.json

@@ -1,9 +1,9 @@
 {
-  "extends": ["@tsconfig/strictest/tsconfig.json", "@tsconfig/node-lts/tsconfig.json"],
+  "extends": ["@tsconfig/strictest/tsconfig", "@tsconfig/node18/tsconfig"],
   "compilerOptions": {
-    "sourceMap": true,
-    "composite": true,
-    "noEmit": true
+    "declaration": true,
+    "noEmit": true,
+    "sourceMap": true
   },
   "exclude": ["build", "coverage"]
 }

yarn.lock

@@ -1058,10 +1058,10 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@tsconfig/node-lts@npm:22.0.1":
-  version: 22.0.1
-  resolution: "@tsconfig/node-lts@npm:22.0.1"
-  checksum: 10c0/9e8dbe98daac8eaebd78fc3aea33ee479e7ec9c6f34550ca024ab48d5f9cbe225de8ab9d56e10cf7416261d3ad72b2657fbb8d560443dafb21eabf615b8ad98e
+"@tsconfig/node18@npm:^18.2.4":
+  version: 18.2.4
+  resolution: "@tsconfig/node18@npm:18.2.4"
+  checksum: 10c0/cdfd17f212660374eb2765cd5907b2252e43cfa2623cd52307a49f004327ef49bbe7d53c78b0aca57f33e9a5cb0d7d2eb5ded9be1235e6212f65c9f0699322b6
   languageName: node
   linkType: hard
 
@@ -1194,6 +1194,15 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@types/node@npm:18":
+  version: 18.19.112
+  resolution: "@types/node@npm:18.19.112"
+  dependencies:
+    undici-types: "npm:~5.26.4"
+  checksum: 10c0/e3421fb3c755337a0477014b235026d914cac8266b67de5867d778b2d4ce2ed0c8052c922e61810f2364d6b29ee24c6ea18671c5636076371b82b0d3e480fbef
+  languageName: node
+  linkType: hard
+
 "@types/promise-retry@npm:1.1.6":
   version: 1.1.6
   resolution: "@types/promise-retry@npm:1.1.6"
@@ -2912,8 +2921,9 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "expo-server-sdk@workspace:."
   dependencies:
-    "@tsconfig/node-lts": "npm:22.0.1"
+    "@tsconfig/node18": "npm:^18.2.4"
     "@tsconfig/strictest": "npm:2.0.5"
+    "@types/node": "npm:18"
     "@types/node-fetch": "npm:2.6.12"
     "@types/promise-retry": "npm:1.1.6"
     eslint: "npm:9.26.0"
@@ -6505,6 +6515,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"undici-types@npm:~5.26.4":
+  version: 5.26.5
+  resolution: "undici-types@npm:5.26.5"
+  checksum: 10c0/bb673d7876c2d411b6eb6c560e0c571eef4a01c1c19925175d16e3a30c4c428181fb8d7ae802a261f283e4166a0ac435e2f505743aa9e45d893f9a3df017b501
+  languageName: node
+  linkType: hard
+
 "undici-types@npm:~6.20.0":
   version: 6.20.0
   resolution: "undici-types@npm:6.20.0"