Fix panic in checker

antonmedv · antonmedv · commit 87e38b17441f · 2023-08-17T23:16:33.000+02:00
diff --git a/checker/checker.go b/checker/checker.go
@@ -804,6 +804,9 @@ func (v *visitor) checkArguments(name string, fn reflect.Type, method bool, argu
 
 func (v *visitor) ClosureNode(node *ast.ClosureNode) (reflect.Type, info) {
 	t, _ := v.visit(node.Node)
+	if t == nil {
+		return v.error(node.Node, "closure cannot be nil")
+	}
 	return reflect.FuncOf([]reflect.Type{anyType}, []reflect.Type{t}, false), info{}
 }
 
diff --git a/compiler/compiler_test.go b/compiler/compiler_test.go
@@ -283,6 +283,7 @@ func TestCompile(t *testing.T) {
 func TestCompile_panic(t *testing.T) {
 	tests := []string{
 		`(TotalPosts.Profile[Authors > TotalPosts == get(nil, TotalLikes)] > Authors) ^ (TotalLikes / (Posts?.PublishDate[TotalPosts] < Posts))`,
+		`one(Posts, nil)`,
 	}
 	for _, test := range tests {
 		t.Run(test, func(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -804,6 +804,9 @@ func (v *visitor) checkArguments(name string, fn reflect.Type, method bool, argu`
`804`	`804`
`805`	`805`	`func (v visitor) ClosureNode(node ast.ClosureNode) (reflect.Type, info) {`
`806`	`806`	`t, _ := v.visit(node.Node)`
	`807`	`+ if t == nil {`
	`808`	`+ return v.error(node.Node, "closure cannot be nil")`
	`809`	`+ }`
`807`	`810`	`return reflect.FuncOf([]reflect.Type{anyType}, []reflect.Type{t}, false), info{}`
`808`	`811`	`}`
`809`	`812`
Original file line number	Diff line number	Diff line change
`@@ -283,6 +283,7 @@ func TestCompile(t *testing.T) {`
`283`	`283`	`func TestCompile_panic(t *testing.T) {`
`284`	`284`	`tests := []string{`
`285`	`285`	`(TotalPosts.Profile[Authors > TotalPosts == get(nil, TotalLikes)] > Authors) ^ (TotalLikes / (Posts?.PublishDate[TotalPosts] < Posts))`,
	`286`	+ `one(Posts, nil)`,
`286`	`287`	`}`
`287`	`288`	`for _, test := range tests {`
`288`	`289`	`t.Run(test, func(t *testing.T) {`