Better error message for predicate with sequence

antonmedv · antonmedv · commit fdba92bdadc2 · 2025-03-08T12:14:13.000+01:00
diff --git a/parser/parser.go b/parser/parser.go
@@ -619,6 +619,9 @@ func (p *parser) parsePredicate() Node {
 		node = p.parseSequenceExpression()
 	} else {
 		node = p.parseExpression(0)
+		if p.current.Is(Operator, ";") {
+			p.error("wrap predicate with brackets { and }")
+		}
 	}
 	p.depth--
 
diff --git a/parser/parser_test.go b/parser/parser_test.go
@@ -925,7 +925,7 @@ func TestParse_error(t *testing.T) {
  | .....^`},
 		{
 			`map(ls, 1; 2; 3)`,
-			`unexpected token Operator(";") (1:10)
+			`wrap predicate with brackets { and } (1:10)
  | map(ls, 1; 2; 3)
  | .........^`,
 		},

Original file line number	Diff line number	Diff line change
`@@ -619,6 +619,9 @@ func (p *parser) parsePredicate() Node {`
`619`	`619`	`node = p.parseSequenceExpression()`
`620`	`620`	`} else {`
`621`	`621`	`node = p.parseExpression(0)`
	`622`	`+ if p.current.Is(Operator, ";") {`
	`623`	`+ p.error("wrap predicate with brackets { and }")`
	`624`	`+ }`
`622`	`625`	`}`
`623`	`626`	`p.depth--`
`624`	`627`
Original file line number	Diff line number	Diff line change
`@@ -925,7 +925,7 @@ func TestParse_error(t *testing.T) {`
`925`	`925`	\| .....^`},
`926`	`926`	`{`
`927`	`927`	`map(ls, 1; 2; 3)`,
`928`		- `unexpected token Operator(";") (1:10)
	`928`	+ `wrap predicate with brackets { and } (1:10)
`929`	`929`	`\| map(ls, 1; 2; 3)`
`930`	`930`	\| .........^`,
`931`	`931`	`},`