Added missing assertions on the increment Store method

Author: adrianprelipcean

test/stores/store_aggregated_ip.spec.ts

@@ -1,4 +1,5 @@
 import 'mocha'
+import { assert } from 'chai'
 
 import { Pool } from 'pg'
 import sinon, { SinonMock, SinonStub } from 'sinon'
@@ -56,20 +57,21 @@ describe('Postgres Store Aggregated IP', () => {
 
 	it('increment function should follow expected business logic', async () => {
 		let pool = new Pool()
+		let dbCount = 1
 
 		isSessionValidSpy.returns(true)
 		query.onFirstCall().returns({
 			rows: [
 				{
-					count: 1,
+					count: dbCount,
 				},
 			],
 		})
 		let testStore = new PostgresStore({}, 'test')
 		testStore.pool = pool
 		testStore.session = newCreatedSession
 
-		await testStore.increment('key')
+		let incrementCount = await testStore.increment('key')
 		sinon.assert.callCount(isSessionValidSpy, 1)
 		sinon.assert.calledWith(
 			query,
@@ -81,6 +83,14 @@ describe('Postgres Store Aggregated IP', () => {
             `,
 			['key', newCreatedSession.id],
 		)
+		assert.equal(incrementCount.totalHits, dbCount)
+		assert.isTrue(
+			(incrementCount.resetTime?.getMilliseconds() ||
+				new Date().getMilliseconds()) -
+				(newCreatedSession.expires_at?.getMilliseconds() ||
+					new Date().getMilliseconds()) <
+				10,
+		)
 	})
 
 	it('decrement function should follow expected business logic', async () => {

test/stores/store_individual_ip.spec.ts

@@ -1,4 +1,5 @@
 import 'mocha'
+import { assert } from 'chai'
 
 import { Pool } from 'pg'
 import sinon, { SinonMock, SinonStub } from 'sinon'
@@ -56,6 +57,7 @@ describe('Postgres Store Individual IP', () => {
 
 	it('increment function should follow expected business logic', async () => {
 		let pool = new Pool()
+		let dbCount = 1
 
 		isSessionValidSpy.returns(true)
 		query.onFirstCall().returns({
@@ -65,15 +67,15 @@ describe('Postgres Store Individual IP', () => {
 		query.onSecondCall().returns({
 			rows: [
 				{
-					count: 1,
+					count: dbCount,
 				},
 			],
 		})
 		let testStore = new PostgresStoreIndividualIP({}, 'test')
 		testStore.pool = pool
 		testStore.session = newCreatedSession
 
-		await testStore.increment('key')
+		let incrementCount = await testStore.increment('key')
 		sinon.assert.callCount(isSessionValidSpy, 1)
 		sinon.assert.calledWith(
 			query,
@@ -85,6 +87,14 @@ describe('Postgres Store Individual IP', () => {
 			'SELECT count(id) AS count FROM rate_limit.individual_records WHERE key = $1 AND session_id = $2',
 			['key', newCreatedSession.id],
 		)
+		assert.equal(incrementCount.totalHits, dbCount)
+		assert.isTrue(
+			(incrementCount.resetTime?.getMilliseconds() ||
+				new Date().getMilliseconds()) -
+				(newCreatedSession.expires_at?.getMilliseconds() ||
+					new Date().getMilliseconds()) <
+				10,
+		)
 	})
 
 	it('decrement function should follow expected business logic', async () => {

test/util/session_handler.spec.ts

@@ -1,5 +1,5 @@
 import 'mocha'
-import { assert, expect } from 'chai'
+import { assert } from 'chai'
 import {
 	calculateNextResetTime,
 	getSession,