feat(redirect): enhance redirect handlers with additional test cases

Author: bjohansebas

recipes/magic-redirect/src/workflow.ts

@@ -6,28 +6,47 @@ async function transform(root: SgRoot<Js>): Promise<string> {
 
   // Helper function to find the request parameter name
   function findRequestParamName(node: any): string {
-    // Start from the call expression and traverse up to find function parameters
     let current = node
+    const funcKinds = new Set([
+      'function_declaration',
+      'function_expression',
+      'function',
+      'arrow_function',
+      'method_definition',
+    ])
+
     while (current) {
       const parent = current.parent()
       if (!parent) break
-      // Check if we're in a function declaration or arrow function
-      if (parent.kind() === 'function_declaration' || parent.kind() === 'arrow_function') {
-        const params = parent.field('parameters')
 
-        if (params && params.children().length > 0) {
-          const firstParam = params.children()[1]
-          if (firstParam.kind() === 'required_parameter') {
-            const pattern = firstParam.field('pattern')
-            if (pattern && pattern.kind() === 'identifier') {
-              return pattern.text()
+      const kind = parent?.kind()
+      if (kind && funcKinds.has(kind)) {
+        const candidateFields = ['parameters', 'parameter', 'formal_parameters', 'params']
+        let params: any = null
+
+        for (const f of candidateFields) {
+          params = parent?.field(f)
+          if (params) break
+        }
+
+        if (params) {
+          const children = typeof params.children === 'function' ? params.children() : []
+          if (children && children.length > 0) {
+            const first = children[1]
+
+            if (first?.kind() === 'required_parameter') {
+              const pattern = first?.field('pattern')
+              if (pattern && typeof pattern.kind === 'function' && pattern.kind() === 'identifier') {
+                return pattern.text()
+              }
             }
           }
         }
       }
 
       current = parent
     }
+
     return 'req' // default fallback
   }
 

recipes/magic-redirect/tests/expected/redirect.ts

@@ -9,12 +9,33 @@ app.get("/", function (req, res) {
 app.get("/", (req, res) => {
   res.redirect(req.get("Referrer") || "/");
 });
+app.get("/", (req, res) => {
+  res.redirect("testing");
+});
+app.get("/", (req, res) => {
+  res.redirect();
+});
 app.get("/articles", function (request, response) {
   response.redirect(request.get("Referrer") || "/");
 });
 app.get("/articles", (request, response) => {
   response.redirect(request.get("Referrer") || "/");
 });
+app.get("/articles", function (request, response) {
+  response.redirect("testing");
+});
 app.get("/articles", function (_req, _res) {
   redirect("back");
 });
+
+export function handler(requests, response) {
+  response.redirect(requests.get("Referrer") || "/");
+}
+
+export function handleRedirect(req: any) {
+  req.redirect(req.get("Referrer") || "/");
+}
+
+export function handlerWith(req: any, res: any) {
+  res.redirect(req.get("Referrer") || "/");
+}

recipes/magic-redirect/tests/input/redirect.ts

@@ -9,12 +9,33 @@ app.get("/", function (req, res) {
 app.get("/", (req, res) => {
   res.redirect("back");
 });
+app.get("/", (req, res) => {
+  res.redirect("testing");
+});
+app.get("/", (req, res) => {
+  res.redirect();
+});
 app.get("/articles", function (request, response) {
   response.redirect("back");
 });
 app.get("/articles", (request, response) => {
   response.redirect("back");
 });
+app.get("/articles", function (request, response) {
+  response.redirect("testing");
+});
 app.get("/articles", function (_req, _res) {
   redirect("back");
 });
+
+export function handler(requests, response) {
+  response.redirect('back');
+}
+
+export function handleRedirect(req: any) {
+  req.redirect('back');
+}
+
+export function handlerWith(req: any, res: any) {
+  res.redirect('back');
+}