fix res.write proxy

Author: fernandolguevara

index.js

@@ -106,13 +106,14 @@ function compression (options) {
         // HACK: node doesn't expose internal errors,
         // we need to fake response to throw underlying errors type
         var fakeRes = new ServerResponse({})
-        if (!res.destroyed) {
-          fakeRes.destroyed = fakeRes.finished = true
-        } else {
-          fakeRes.destroyed = true
-        }
+        fakeRes.on('error', function (err) {
+          res.emit('error', err)
+        })
+        fakeRes.destroyed = res.destroyed
+        fakeRes.finished = res.finished || ended
         // throw ERR_STREAM_DESTROYED or ERR_STREAM_WRITE_AFTER_END
-        return _write.call(fakeRes, chunk, encoding, callback)
+        _write.call(fakeRes, chunk, encoding, callback)
+        return false
       }
 
       if (!this._header) {

test/compression.js

@@ -59,7 +59,6 @@ describe('compression()', function () {
           res.write(1)
         } catch (err) {
           assert.ok(err.code === 'ERR_INVALID_ARG_TYPE')
-          res.statusCode = 500
           res.flush()
           res.end()
         }
@@ -68,7 +67,7 @@ describe('compression()', function () {
       request(server)
         .get('/')
         .set('Accept-Encoding', 'gzip')
-        .expect(500, done)
+        .expect(200, done)
     })
 
     it('res.write({}) should fire ERR_INVALID_ARG_TYPE', function (done) {
@@ -78,7 +77,6 @@ describe('compression()', function () {
           res.write({})
         } catch (err) {
           assert.ok(err.code === 'ERR_INVALID_ARG_TYPE')
-          res.statusCode = 500
           res.flush()
           res.end()
         }
@@ -87,17 +85,16 @@ describe('compression()', function () {
       request(server)
         .get('/')
         .set('Accept-Encoding', 'gzip')
-        .expect(500, done)
+        .expect(200, done)
     })
 
-    it('res.write(null) should fire ERR_STREAM_NULL_VALUES', function (done) {
+    it('res.write(null) should fire ERR_INVALID_ARG_TYPE or ERR_STREAM_NULL_VALUES', function (done) {
       var server = createServer({ threshold: 0 }, function (req, res) {
         res.setHeader('Content-Type', 'text/plain')
         try {
           res.write(null)
         } catch (err) {
-          assert.ok(err.code === 'ERR_STREAM_NULL_VALUES')
-          res.statusCode = 500
+          assert.ok(err.code === 'ERR_INVALID_ARG_TYPE' || err.code === 'ERR_STREAM_NULL_VALUES')
           res.flush()
           res.end()
         }
@@ -106,7 +103,7 @@ describe('compression()', function () {
       request(server)
         .get('/')
         .set('Accept-Encoding', 'gzip')
-        .expect(500, done)
+        .expect(200, done)
     })
   })